From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dWJ+J2WCB2Y9sBsAWB0awg (envelope-from ) for ; Fri, 29 Mar 2024 23:09:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=y22Zg1cO; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 89A011E0C0; Fri, 29 Mar 2024 23:09:25 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6DF1B1E08C for ; Fri, 29 Mar 2024 23:09:23 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B3473858C62 for ; Sat, 30 Mar 2024 03:09:23 +0000 (GMT) Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by sourceware.org (Postfix) with ESMTPS id F2FFE3858D28 for ; Sat, 30 Mar 2024 03:09:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F2FFE3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F2FFE3858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::531 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711768145; cv=none; b=TYMO4T7zpE1PluVG5rskJW6XczROZGFpFyOYbrmJthsvFl7p7ionQJDikN0jETkpbpDwJA6ItJAeF0F8gHUIzE2tRJfWdhB8gukYNVJxMW19+9WivFi7YPSe8kcPoVYbnfBLL9DQerR8HYEB5L7P96115f6E/kS1NTItIyOt0VE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1711768145; c=relaxed/simple; bh=lh8bujlHNCal5jEp/nWFBbn8j4MU6MfHJ9/d8tCvDAY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=nK7Zljl1GIzs8mShu0R4MTCpZ0txmQXZd4s2xc2F8auEs1eJ6q6dalNOCr90ncaRZCQMymwBRqd9BHvHKEUrjtely3Zf7gOiC3IgIInWBomMrsDaF6bLiRtSi9jjtHUuPNpTvc6WEsHNeT4S8VXD+cXyezI3K+Dv+WH/N1ydl5k= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x531.google.com with SMTP id 41be03b00d2f7-5f034b4dcecso1686243a12.1 for ; Fri, 29 Mar 2024 20:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1711768141; x=1712372941; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=lh8bujlHNCal5jEp/nWFBbn8j4MU6MfHJ9/d8tCvDAY=; b=y22Zg1cOhxxktaEnSnG777FQ0lCwb2gxk2an4pGVw+ROKjyTcW2B/WzWlzxoIW3kPW qufXopPPJvYL2xjFsooA6mPRaVu70wJTSupWgGjiatM9KBZjKniZjMq/Ird5RSAPl6b2 IHHnCwiXOlvdHtOkhT97cLY90OuPUkmz9wId77e5rKo21AGxv6zQdg2KMQapiPiBY/8P Svn3eo4zvdcusfe0WvDDkoZSBlopy4SJT4uZyirHAXPDqRMt2n307VT1cTmac1eBc8gu MaaoWC76z9eJGBfwlcI6EL+Igo5wXprn9x1XfV+ERQWSWMUUMuP03nN31zvcict+Eq1k sy/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711768141; x=1712372941; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lh8bujlHNCal5jEp/nWFBbn8j4MU6MfHJ9/d8tCvDAY=; b=JEQKM2xo4Bo/7ZAjM3YVwXOcCGz8d/p3wsOivYNpifazrVuzujyJAZGQv4jwOKfV2Z DicI4ouGf4xJP0hbsL/Ux2SKo0iW1xq2rj1GYXX0HiuHXTkwkHQNrS8A9xScoKnqrJ0w CZ2Q7/BGaRqlUyRtZ78pJ5XGf6jV9CkqsLB5wGNjnIa1dzK20podznyMVFWx8jr1WqWy +Y3+UNDCLmxRicMpL6N8NeeD+JQwwt5pZyeFYpip8ZOf8e6g9eZuVQdpXXDu0AfNcipE /0N9oyChOdrEsxR8adGxEo3nfLVoK1LGd7cGo7oRh5DrYZoOYlwe/4b3BUxTRYBlNrBi mFpA== X-Gm-Message-State: AOJu0YxNz+VTbuQfwFg0DA5ZFAqDH4TRP6PoynAi9/a5xUOpIiOAqONp HI8GPTywBVWo6RFnl9D73P9M4IKJ3aHEX0sneRPSk03ecIBntQvlMLOn1uLNv7axZr8WYKduO9Y m X-Google-Smtp-Source: AGHT+IF5Dh/gxUsJpysvSg9rt8TMa6kjTZeAMRcg8D7xBDhOzdTPNhfzDc25+nfMA42i+tc8jmfL+w== X-Received: by 2002:a17:903:41c7:b0:1de:f0f0:90ac with SMTP id u7-20020a17090341c700b001def0f090acmr5820939ple.11.1711768140625; Fri, 29 Mar 2024 20:09:00 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:2981:86:c711:2bee]) by smtp.gmail.com with ESMTPSA id u9-20020a170903124900b001e0f55082ebsm4187031plh.56.2024.03.29.20.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Mar 2024 20:09:00 -0700 (PDT) From: Thiago Jung Bauermann To: Gustavo Romero Cc: gdb-patches@sourceware.org, luis.machado@arm.com Subject: Re: [PATCH v2 4/4] gdb: Add new remote packet to check if address is tagged In-Reply-To: <20240328224850.2785280-5-gustavo.romero@linaro.org> (Gustavo Romero's message of "Thu, 28 Mar 2024 22:48:50 +0000") References: <20240328224850.2785280-1-gustavo.romero@linaro.org> <20240328224850.2785280-5-gustavo.romero@linaro.org> User-Agent: mu4e 1.12.2; emacs 29.1 Date: Sat, 30 Mar 2024 00:08:57 -0300 Message-ID: <87r0fs76wm.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Just one more suggestion that occurred to me later: Gustavo Romero writes: > For supporting the new packet, a new target hook is introduced, > check_memtag_addr, which is used instead of the gdbarch_tagged_address_p > gdbarch hook in the upper layers (printcmd.c). "check_memtag_addr" is a bit vague: what does it check? This confused me a bit when I was reading the code with these patches applied. Alternatives I can think of are "is_addr_tagged", or "tagged_address_p". I'm not too fond of the "_p" suffix, but it has the advantage of being consistent with the existing gdbarch hook so it may be preferable in this case. Ah, one other thing that just occurred to me: I think this warrants an entry in gdb/NEWS. -- Thiago