From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id eFSbBh0aY2doHiEAWB0awg (envelope-from ) for ; Wed, 18 Dec 2024 13:53:17 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=BIM8BV4j; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 169FA1E097; Wed, 18 Dec 2024 13:53:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C7071E091 for ; Wed, 18 Dec 2024 13:53:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B9843858C3A for ; Wed, 18 Dec 2024 18:53:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B9843858C3A Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=BIM8BV4j Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 1DAF53858D28 for ; Wed, 18 Dec 2024 18:46:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1DAF53858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1DAF53858D28 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734547585; cv=none; b=IXQITtG/FPTFj9PSekqERjjio9dCA5BTTjhDsrdAr1Dw6+dcx/CrxXRZtzPwUONTxduqLRgh1ewMUNjohRIXj21L9WUOv6GVsyQLIEkEzXAhLO72FU8c4QbroQTd932zbGwdMWvJzXRenfd8yBBT5Amis5PNp/mBWuocMw3jjtk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1734547585; c=relaxed/simple; bh=EFz1LYpVjJSlE5VouhDUzfRk+iuw2bRYL7SETvZbHO4=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=GVmnkBHNVPjKAI+I5SNXz9dTaKEe4AK6h1E+QZCDEY/0gQARrzW04WH5YGMPvZ1mOOhTy5nwpneGrShE2wHODJJSnVIWHn9rXMxPiugNFT+oovocZ6xsWBMPP3pV1dg5msC+wO+f290SYS36MfRg6wOu3BdM+qWlSmwiUwE3LW4= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1DAF53858D28 Received: from eig-obgw-6006a.ext.cloudfilter.net ([10.0.30.182]) by cmsmtp with ESMTPS id Nvy9t9yiHqvuoNz3wt8mFr; Wed, 18 Dec 2024 18:46:24 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id Nz3vtcM1RfkSoNz3vtTK0d; Wed, 18 Dec 2024 18:46:23 +0000 X-Authority-Analysis: v=2.4 cv=dtLdCUg4 c=1 sm=1 tr=0 ts=6763187f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RZcAm9yDv7YA:10 a=ItBw4LHWJt0A:10 a=QyXUC8HyAAAA:8 a=uW45uwEIWkwEzeb4dOEA:9 a=ZXulRonScM0A:10 a=6Ogn3jAGHLSNbaov7Orx:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=HaXST+/fT9kdkzM/1y/1RzhcPFkDtfCyxN7cd41+z3o=; b=BIM8BV4j+sL2sdPFeuc3bv0kLl UYKklEWTqD5nZLkTBexg3Rze6sFagas9bZX82N2EdeK08dMYbFPcGVn1IQRBgwY72kHDy/JgOvHys GLLeI1Dc6mSWWPwB7Y9BLYUMh; Received: from 97-122-113-155.hlrn.qwest.net ([97.122.113.155]:57322 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1tNz3u-000CLS-2C; Wed, 18 Dec 2024 11:46:22 -0700 From: Tom Tromey To: Tankut Baris Aktemur Cc: gdb-patches@sourceware.org, tom@tromey.com, aburgess@redhat.com Subject: Re: [PATCH v3 3/3] gdb, gdbserver: introduce the 'x' RSP packet for binary memory read In-Reply-To: <89ed8debd626735ae02fa1f2fc8e7036c1867329.1712648465.git.tankut.baris.aktemur@intel.com> (Tankut Baris Aktemur's message of "Tue, 9 Apr 2024 09:48:11 +0200") References: <89ed8debd626735ae02fa1f2fc8e7036c1867329.1712648465.git.tankut.baris.aktemur@intel.com> X-Attribution: Tom Date: Wed, 18 Dec 2024 11:46:21 -0700 Message-ID: <87r064bzia.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.113.155 X-Source-L: No X-Exim-ID: 1tNz3u-000CLS-2C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-113-155.hlrn.qwest.net (murgatroyd) [97.122.113.155]:57322 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfOeWNipu3fwkxAeFinXyyQX5TjdfBHAJM9tZlZRhjVhnF7inDXqUBahX7yjidP3k8MpivKb1rA44ys0C7Gva+ULhvmU0DzYVXmv6xmeOPOyUMOwG4qgT 8x0D/5RFu9A5oCZAXl0vNOzoUekKWKQl6SrP0g8MPnE22G/KPQxf1qWf+iPvTQjtn8aMUmu6VIp6LpstpSH+awnuvulx8qB60mk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Tankut" == Tankut Baris Aktemur writes: Tankut> Introduce an RSP packet, 'x', for reading from the remote server Tankut> memory in binary format. The binary write packet, 'X' already exists. Tankut> The 'x' packet is essentially the same as 'm', except that the Tankut> returned data is in binary format. For transferring relatively large Tankut> data from the memory of the remote process, the 'x' packet can reduce the Tankut> transfer costs. I don't think this was re-reviewed? Sorry about the delay on this. Tankut> + else if (cs.own_buf[0] == 'x') Tankut> + { Tankut> + decode_x_packet (&cs.own_buf[1], &mem_addr, &mem_len); Tankut> + mem_buf = (unsigned char *) xmalloc (mem_len); Tankut> + if (read_inferior_memory (mem_addr, mem_buf, mem_len) == 0) Tankut> + { [...] It's sort of weird that this code is copied in 3 places. However, that's not a problem you invented, maybe we can file a bug and/or clean this up later. Tom