From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wcDqNLdpwGiw/j0AWB0awg (envelope-from ) for ; Tue, 09 Sep 2025 13:53:59 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=AaD/DH4O; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D3C2E1E04C; Tue, 09 Sep 2025 13:53:59 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1ED9D1E04C for ; Tue, 09 Sep 2025 13:53:59 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A0D423858CDB for ; Tue, 9 Sep 2025 17:53:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A0D423858CDB Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=AaD/DH4O Received: from mail-il1-x12a.google.com (mail-il1-x12a.google.com [IPv6:2607:f8b0:4864:20::12a]) by sourceware.org (Postfix) with ESMTPS id D058F3858D35 for ; Tue, 9 Sep 2025 17:53:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D058F3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D058F3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::12a ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757440408; cv=none; b=S1jqmI/YoHVQmuTBRFUdfs5/rmx9yXEpTHv1bJJNl89Drpr3WOBDdVpaSPLrl2oB7E73jhsFUOHZTCP6id42sdP0PvVshyIcrqw4/OcfOn/xR60BC4euyZ555ObGmBb6+qLXk4Us/5J3Nj4ikhHs4shMSblSOTynubR4Q9B3cDs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757440408; c=relaxed/simple; bh=pRxRz06lizS0tHFq/blUSSn6+vzxaFpicdKcFabVvlc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=iT6PAADHokBsFY/yCoOXoYtjmNjrdw+7WO5CZfllxvmsfkxbZnnZLA2PBS3N+cgO64DSELjirtJFG97QjobRfPa2di5JxKiXfMklNBEDNlLkTDVqIeCwhgYkCUACEwmo3RnO8iPZUKHMZA1Nx2ejgrwX20TwzCxgC5rHI17lsbA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D058F3858D35 Received: by mail-il1-x12a.google.com with SMTP id e9e14a558f8ab-412a2fe2f31so3712345ab.3 for ; Tue, 09 Sep 2025 10:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1757440407; x=1758045207; darn=sourceware.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZUexWLCf0FzMr/KMu6eQELmZPRcEVVR0zCRQDEvJQ4k=; b=AaD/DH4Om5jpGP6CYUTbjjJV/RHOoyl5oZYUPo1M6bNw983CCufjfmQ0jQLACj8Zs+ 2ZRudBS5riNNllBGY5EMlH/mEVL046BQR2ij35YzkkdaBK/G7JD1kFh1j+O6PFnnwlJS 1hyFJBxszZ7Y4dIOWAyDex8LEqdndnq2Dsk8AOtuWM+VUs2fGdWxrpq9FN9f95jbO4DA GKEpDgL+easdUlm5zRL/cT02yVLq3Y6bZ2OwMXk3Bbnsdsfrbt4jlQLUJawtNWo0tjZf lXl88I15E5r9vxh2yyUiXEuEQ8TN//SZRtFu6XUfNyLBjg5MIPtdL/qc1WTT7corBqoz awUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757440407; x=1758045207; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZUexWLCf0FzMr/KMu6eQELmZPRcEVVR0zCRQDEvJQ4k=; b=AlU5dMJabUT8IW01wHt/VQOcNr5VLs3SbNW8NwhA3JtIOcRmsMfO51R7DE1RjADMMn GyceM2w005moM1LwEdR6sy9pyy39cGul5Wci1XHgQ2qh7DXLjtKw5Oghu1NA5We9Dx6Y mY6oWP0cVfbBQM3grW9A9OSh/bSWnoP8+hUmvwicTwv4XKrlM33GUytrfTL9UaKgq8Kq A1E7/1htFOcq4U0+MwTTRfANjQ9GfpRT73AJOsxmoi+7yr+PeKo9541yn2Une9YKJmGI OERIZK6EyI5OI4w6T6ObMQKEu+Yvcg+JitaUySrn+9aPyVV17FeLoA/64LflC3wgfibC CUKw== X-Forwarded-Encrypted: i=1; AJvYcCXBhUof6L7au40ukiV7ynZpzW7UerMhHydyyWkZabroL2l5K/xYK8jK9WkHDos+/3EH1QFYW5MyoBKkJQ==@sourceware.org X-Gm-Message-State: AOJu0Yz95FGF+29GDyD3HrxKGyT1jasm9dqxoT1v5YA8s2+0sXa0Fzy0 fLk3tHKd8iLz6ULg8DKx2K9ctOyOx7ZT92r+W+bsrSUDDM9tVkhUkn36XbGMwR8/xbsOslr89DD YagA= X-Gm-Gg: ASbGncuPcDagGPiU/HqSBf5eyQR6K1a1nZWXJtFu/M+/cy/r5VI+gDrvz3y4ImHSYgi bniVgl5ugbawkX4B8WCAFnr3AXXbMb92GJZ0p75+X6Wt2nR1pMc68IilAwBQQ42tk23Yeipnzz7 qg8NChQSRycsMgBIKvJG/MKi9A4TqMc+5vuwQjiXqN2SpiGOiIYztAwaYc/dYhw3HjuXd/U8vj4 sTKBdP874nLda2p+ZGZ0gGBcfGVIUfQ5j90KzCywzBoaPcRFBTSe+fBiTpl8jPDDlYARjg+qdOC BX34qoKhDLEFsR4oXPh+CCwtGIg6yvpMWRAU1mzu1dxzPYqlUv7qj6HmamdZKr5kQY5K2SFch+m ITfSMzF2hT/0Pf8RApPtC8MwTFn7/r49bXQ4A0t8SCXUaBAlv4k1c8WMeluFRMMI= X-Google-Smtp-Source: AGHT+IFcjeF9PQxwyq9+X3W7XUHFtB2m6q1mTtF6YGOm0JoM97wE1rk27t3iDo6Dmp30RO09zP8UTw== X-Received: by 2002:a05:6e02:b23:b0:413:5e19:aec4 with SMTP id e9e14a558f8ab-4135e19b4f0mr27467605ab.8.1757440406942; Tue, 09 Sep 2025 10:53:26 -0700 (PDT) Received: from bapiya (97-122-110-68.hlrn.qwest.net. [97.122.110.68]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-50d8f0d5787sm9974816173.19.2025.09.09.10.53.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Sep 2025 10:53:26 -0700 (PDT) From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 0/3] Use gnulib c-ctype module, not In-Reply-To: (Simon Marchi's message of "Wed, 20 Aug 2025 13:14:33 -0400") References: <20250806-gnulib-c-ctype-v1-0-10f33e9f22a4@adacore.com> <87h5yiq32b.fsf@tromey.com> X-Attribution: Tom Date: Tue, 09 Sep 2025 11:53:25 -0600 Message-ID: <87qzwfpl62.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == Simon Marchi writes: Simon> As far as I'm concerned, this patch series LGTM, I'm not aware of better Simon> alternatives. Simon> Approved-By: Simon Marchi I'm going to check this in now. Just as a reminder to everyone, gdb should generally use these new "c-ctype" wrapper functions and not . One idea I had for enforcement was to write a new pre-commit script that looked for includes of ctype.h or safe-ctype.h. WDYT? Tom