From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AQxDMzoOwmgabT8AWB0awg (envelope-from ) for ; Wed, 10 Sep 2025 19:48:10 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=o+w2hEmp; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CD3791E0BA; Wed, 10 Sep 2025 19:48:10 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 032A21E047 for ; Wed, 10 Sep 2025 19:48:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 75C953858C30 for ; Wed, 10 Sep 2025 23:48:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 75C953858C30 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=o+w2hEmp Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id E1F7B3858D35 for ; Wed, 10 Sep 2025 23:47:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1F7B3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E1F7B3858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::436 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757548058; cv=none; b=ioOjqXxZn68CBIoltujnq7G/btsw8goUfiWscT+gI/uCYEVOaM6BtBgF0DJgLmqH0ZoAdcZD/wbJW2w3I3a/FNKtTTIYQHPC28qQLAno7WZ6/guAI0jjm8KyW9cCbiRikSyjg5Ij/yrpX1jh4TTK0jO2+ylpj/t3GQRNp2TwilI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757548058; c=relaxed/simple; bh=s9bDKNEiK7wFmUiWMcbuUFr3jbC0IijzRSKc1Txey1c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=XObt2wxaku2si7aSXpLJ0QJ5f1sBjkIOVWo9kzjRlk+cSInWbDmfFSvlfRFJI1Uc1HpeNp8sN2+2vjKioQh9k9sF5qAznTa89x1xhKF6KAdO/TTtrdiSIDmJaFQOXn8Z8yfT/iJmgjUteGmZ118PclYwKnkViGdb61WC8lc/13Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E1F7B3858D35 Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-7722c8d2694so120258b3a.3 for ; Wed, 10 Sep 2025 16:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1757548057; x=1758152857; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=RpBi8C+QkrapdNMbX0WHEPkk3DhOaBqoyDs8e1JPyBo=; b=o+w2hEmpaE83kdCH9UA8+XqZ+O7sICIOhQv0A9cHnQzJ6Carl7Jx2jP0tS0yzNUWaT EvhF9xLNqsm7QAFBSfyifvoifhhJyM7DX4M1sXM0QzMEo1LT1umO9g6lg/951Qv3cPSH UyqS4tRzK8JOtsHlN4Td4684pe3WwIj/b/sOSd+IZVhXXvKhUehZQvdBS6/rjb3cUZY+ kHNAav16ku6KaFGG3VoANVhcHQXtGEE8WVOxNZXFxPgKh7YTJMloqG4LPPweM6ex6pBs 2j+b8Uj/WkZZWD407zVunXteHXXGcKpOI5v1hj1xC4U0FWI847+lm6GXkYDoBxX7yVcC HWDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757548057; x=1758152857; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RpBi8C+QkrapdNMbX0WHEPkk3DhOaBqoyDs8e1JPyBo=; b=t6RfNS4fgI+HxZJcZ1yN7W6Jah+Eijmj77wgcJM1P4RsQZjQGePIY/NSRBoKuw2dE8 wSYfiEoGnwq7RTWpZNEdx/LU6xmrRlY5F7XMm29m0CHQspsQuTvzgasYNdzJNHRiIZhV i419G14lV6TWYJhHu3dBahnYQaN0f9YQIV245wwAalvOQH8Nnwbwat6Pd5YT3NUFE27r BFTb+ku3kHLPEstwO6WyfxA2S8e23xWry59xGwl50y5SBRWvbOVMSZUfkV0bMTOREe6w m1ZW0TXOIkKHVIpC3uGjHOajf6m9kd+55/Ly1yu0WjttWm68KuZPb3Wz9YL73ruqhk0a cN/g== X-Gm-Message-State: AOJu0YwtOOgsPhFQLdJroxkCusx9pHctt/Qdln/RbksGhM0/+R9MVJYc 4CiWNxNRcvbcllLGDHHKSyTTBDyy/kSmWbbVb+5AVh/bw9owjucf9Wymg5rUZNIyzCI= X-Gm-Gg: ASbGncun0U/ugoLPOAzQ04oj1o/cW0H9ltO5vJlHxdt3YhJXxwoIJ6bAjUAlsQVypxV yeZ9a6Znw5fuI7E1erhWtx/UDmGo9p1o0Mkl2FoBnOn2yVg8p/V7v86EZPQUofRc/y702nS0WcD 2RnnHT7+ZTEtcIZvNjvAkeR7n4TxcXdJ1pyZElrre2nwCa8ww2HGEj2B+/Rs3Be4VcazwmSYr0H w6DYjrM7iSqpWxXLnJSxsXpTEypPOvxCWEIigCTJ6TPb4htiMgTgVnQfIVStwy/hVNKyptMdSBF 0sJh0YIEh6eO96EduXssPpEWFbhVgzye0OykMyYTG2BlgN3XjF4sb8Z6ARMTtvM6UTorgdkKSrO NpLBjz4OuK19+KUYviuWOx/hdsctW6KkAsPDv0AUR1BM= X-Google-Smtp-Source: AGHT+IGRaWudoljC9DDPbuUszEsVsEGXokin5/vfF9TeoexPlGPE+aLDVj8CPwisfScZKSbVkkWNbA== X-Received: by 2002:a05:6a00:2e82:b0:770:49ac:50b3 with SMTP id d2e1a72fcca58-7742de91e51mr23767038b3a.24.1757548056939; Wed, 10 Sep 2025 16:47:36 -0700 (PDT) Received: from localhost ([2804:14d:7e39:88d6:e23e:713e:98d0:a6b4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7760793bc1csm14171b3a.18.2025.09.10.16.47.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Sep 2025 16:47:36 -0700 (PDT) From: Thiago Jung Bauermann To: Cc: , Subject: Re: [RFC PATCH 3/5] gdb/aarch64: signal frame support for fpmr In-Reply-To: <20250905131707.77027-4-Ezra.Sitorus@arm.com> (Ezra Sitorus's message of "Fri, 5 Sep 2025 14:17:05 +0100") References: <20250905131707.77027-1-Ezra.Sitorus@arm.com> <20250905131707.77027-4-Ezra.Sitorus@arm.com> User-Agent: mu4e 1.12.11; emacs 30.1 Date: Wed, 10 Sep 2025 20:47:34 -0300 Message-ID: <87qzwd50q1.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org writes: > From: Ezra Sitorus > > Add support for FPMR in signal frames and restore contents of FPMR. > > Manually validated with Shrinkwrap (Arm FVP). > --- > gdb/aarch64-linux-tdep.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c > index acb650db514..b4911d36410 100644 > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -168,6 +168,7 @@ > #define AARCH64_TPIDR2_MAGIC 0x54504902 > #define AARCH64_ZT_MAGIC 0x5a544e01 > #define AARCH64_GCS_MAGIC 0x47435300 > +#define AARCH64_FPMR_MAGIC 0x46504d52 > > /* Defines for the extra_context that follows an AARCH64_EXTRA_MAGIC. */ > #define AARCH64_EXTRA_DATAP_OFFSET 8 > @@ -214,6 +215,9 @@ > /* features_enabled value offset in the GCS signal frame context. */ > #define AARCH64_GCS_CONTEXT_FEATURES_ENABLED_OFFSET 16 > > +/* FPMR constants. */ Missing double space after period. > +#define AARCH64_FPMR_OFFSET 8 > + > /* Holds information about the signal frame. */ > struct aarch64_linux_sigframe > { > @@ -261,6 +265,12 @@ struct aarch64_linux_sigframe > uint64_t gcspr; > /* Flags indicating which GCS features are enabled for the thread. */ > uint64_t gcs_features_enabled; > + > + /* True if we have an FPMR entry in the signal context, false otherwise. */ > + bool fpmr_available = false; > + /* The Floating Point Mode Register. */ > + CORE_ADDR fpmr = 0; > + > }; > > /* Read an aarch64_ctx, returning the magic value, and setting *SIZE to the > @@ -577,6 +587,22 @@ aarch64_linux_read_signal_frame_info (const frame_info_ptr &this_frame, > section += size; > break; > } > + case AARCH64_FPMR_MAGIC: > + { > + gdb_byte buf[8]; > + if (target_read_memory (section + AARCH64_FPMR_OFFSET, > + buf, 8) != 0) This fits into one line. > + { > + warning (_("Failed to read the FPMR section address from the" > + " signal frame context.")); > + section += size; > + break; > + } > + signal_frame.fpmr = extract_unsigned_integer (buf, 8, byte_order); > + signal_frame.fpmr_available = true; > + section += size; > + break; > + } > case AARCH64_EXTRA_MAGIC: > { > /* Extra is always the last valid section in reserved and points to > @@ -740,6 +766,13 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self, > } > } > > + /* Handle FPMR. */ The indentation of this comment is off. > + if (tdep->has_fpmr () && signal_frame.fpmr_available != 0) > + { > + trad_frame_set_reg_value (this_cache, tdep->fpmr_regnum, > + signal_frame.fpmr); > + } > + The curly braces need to be indented two spaces forward. > /* Restore the tpidr2 register, if the target supports it and if there is > an entry for it. */ > if (signal_frame.tpidr2_section != 0 && tdep->has_tls () > @@ -792,6 +825,7 @@ aarch64_linux_sigframe_prev_arch (const frame_info_ptr &this_frame, > aarch64_features features = aarch64_features_from_target_desc (tdesc); > features.vq = sve_vq_from_vl (signal_frame.vl); > features.svq = (uint8_t) sve_vq_from_vl (signal_frame.svl); > + features.fpmr = signal_frame.fpmr_available; > > struct gdbarch_info info; > info.bfd_arch_info = bfd_lookup_arch (bfd_arch_aarch64, bfd_mach_aarch64); I'll comment on this part in my answer to Luis. -- Thiago