From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ic+MLuKUyWg92AYAWB0awg (envelope-from ) for ; Tue, 16 Sep 2025 12:48:34 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Zf+7MTNH; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B5E7C1E0BA; Tue, 16 Sep 2025 12:48:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0AF6D1E04C for ; Tue, 16 Sep 2025 12:48:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8A34E3857400 for ; Tue, 16 Sep 2025 16:48:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8A34E3857400 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=Zf+7MTNH Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 2DA843858C2A for ; Tue, 16 Sep 2025 16:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DA843858C2A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2DA843858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758041280; cv=none; b=jCdFyC3YvQ+Wj05q3XHn/DhTwOq/5rYXTcq0O3q0v3v57w3/gJCPa6OBCFA5qlO6N7eTf/uiNJn3zMqcl5bIKDy+U1Lq+B9HxxkCAzbUa5UVlIm9OKEHttrt/TYxXaazcoPk3v3jNGsXy3PLgrFqy7IPVGgCuIryB1BzlEY4eC8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758041280; c=relaxed/simple; bh=ynRI8BLSfroyluGztpls/QIGHFUpiggLAS2HcJiTIg0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ugG9RzXD9ohzI6n0No6i6uDFlmQlwbs4Y6a8YPXVcANbARS4n5mRsOjxVDF5psdvpw8EVDLBeYVQ/ZE/vZA6+btXAbLYC4WofhbresvFRsbjyvh8mpXjOoTOd6h+Lg0+n+FuVm2X+JegaoSmcPS3wlDJYgf7AgBZD/L59VtTOpU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2DA843858C2A Received: from eig-obgw-6007b.ext.cloudfilter.net ([10.0.30.166]) by cmsmtp with ESMTPS id yUQpuibRELIlMyYqVudk0d; Tue, 16 Sep 2025 16:47:59 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id yYqJupt51cIGayYqJuZlWH; Tue, 16 Sep 2025 16:47:47 +0000 X-Authority-Analysis: v=2.4 cv=I9NlRMgg c=1 sm=1 tr=0 ts=68c994b4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=yJojWOMRYYMA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=xYebAsyXKsC4dVnCY8YA:9 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=BjZMTZNJsoJj2ygq/p64egkuZSW5euDP3OD1p3mDnpA=; b=Zf+7MTNHHv7va9hpc5uDxb6dyO Sk2mxDieaphzYKUKMsNSMOfXri5cYv3b16ExqM9IaNXAh6ExRZUd9KNhb7bDH1urWoWGA4ijjaND1 qLW5cxzW6m5fiDlflnMP2OKw+; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:51904 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.1) (envelope-from ) id 1uyYqJ-00000001EgH-13xy; Tue, 16 Sep 2025 10:47:47 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, Eli Zaretskii Subject: Re: [PATCHv8 1/3] gdb/python: add gdb.Style class In-Reply-To: (Andrew Burgess's message of "Wed, 27 Aug 2025 12:34:10 +0100") References: X-Attribution: Tom Date: Tue, 16 Sep 2025 10:47:45 -0600 Message-ID: <87qzw6l4y6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1uyYqJ-00000001EgH-13xy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (bapiya) [97.122.110.68]:51904 X-Source-Auth: tom+tromey.com X-Email-Count: 5 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCuTmXLzvCJZtJycN+PWUrJ4Yo+Pgekss95P6nNi2Pc4XB8T/2+30TAU9vyYAssdvSTkcyx6pG3bYESZImpYQa6oT4FD992JIKXPVuZsYy+BOyksxS2k +F0bQd+bAv8kpDMQOpBZtqxGh6DQl7dtQL3Rwbe1tiTSxapAjzZSippZxB1we8gZ2cEmINaOZloM645KD/J4/pB5n50pjjbjflk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> +static std::optional Andrew> +stylepy_style_from_name (const char *name, bool *has_intensity_ptr = nullptr, Andrew> + const cmd_list_element **found_cmd_ptr = nullptr) Andrew> +{ Andrew> + std::string cmd_str = std::string ("show style ") + name; Andrew> + Andrew> + struct cmd_list_element *cmd = nullptr; Andrew> + struct cmd_list_element *alias = nullptr; Andrew> + int found; Andrew> + try Andrew> + { Andrew> + struct cmd_list_element *prefix; Andrew> + found = lookup_cmd_composition (cmd_str.c_str (), &alias, &prefix, &cmd); Andrew> + } Andrew> + catch (const gdb_exception &ex) Andrew> + { Andrew> + PyErr_Format (PyExc_RuntimeError, Andrew> + _("style '%s' cannot be found."), name); Andrew> + return {}; Noting this for a later comment... Andrew> +static PyObject * Andrew> +stylepy_apply (PyObject *self, PyObject *args, PyObject *kw) Andrew> +{ Andrew> + style_object *style_obj = (style_object *) self; Andrew> + Andrew> + static const char *keywords[] = { "string", nullptr }; Andrew> + PyObject *input_obj; Andrew> + Andrew> + if (!gdb_PyArg_ParseTupleAndKeywords (args, kw, "O!", keywords, Andrew> + &PyUnicode_Type, &input_obj)) Andrew> + return nullptr; Why "O!" and not "s" here? Andrew> + gdb::unique_xmalloc_ptr Andrew> + input (python_string_to_target_string (input_obj)); target string seems like an unusual choice here. Andrew> + std::string output Andrew> + = string_printf ("%s%s%s", style->to_ansi ().c_str (), input.get (), Andrew> + ui_file_style ().to_ansi ().c_str ()); This can just using "+" which seems a little cleaner. Andrew> + /* Handle named styles. This is harder, we need to write to the actual Andrew> + parameter. First though, look up the named style to see if it has an Andrew> + intensity. HAS_INTENSITY will be set true only if the style exists, Andrew> + and has an 'intensity' setting. */ Andrew> + Andrew> + bool has_intensity = false; Andrew> + (void) stylepy_style_from_name (style_obj->style_name, &has_intensity); Andrew> + if (!has_intensity) Andrew> + { Andrew> + PyErr_Format Andrew> + (PyExc_ValueError, "the intensity of style '%s' is not writable.", Andrew> + style_obj->style_name); Andrew> + return -1; I guess I don't know the Python rule here, but it seems like if stylepy_style_from_name returns {}, then this can set an exception while one is already set. See the snippet above. Instead of the (void) I think it would be a bit better to just check the return result of stylepy_style_from_name, and if it returns an error, just return -1 directly; and only then do the has_intensity check. Tom