From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id esGPFrXw/2i2dgwAWB0awg (envelope-from ) for ; Mon, 27 Oct 2025 18:22:45 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=coG2XLRK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4C5011E0BC; Mon, 27 Oct 2025 18:22:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9D5181E057 for ; Mon, 27 Oct 2025 18:22:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 35DC83858C42 for ; Mon, 27 Oct 2025 22:22:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 35DC83858C42 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=coG2XLRK Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id D76973858D20 for ; Mon, 27 Oct 2025 22:22:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D76973858D20 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D76973858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761603730; cv=none; b=jZukMABRiShQA4+XDjIQRVypaqFnCgX6yrhr3Ez6mpoPEDw0RUomqdKpGT3Tf+CKmIZ3aoL5ak7/2qw6KwhEyuXdLkLkZPLby7v25jtuNxyz3filgzEFteVDY7OVeTCjpZq7F+CnKwS6omO9eaP1JQxBKa8jNca+NM8zDeKMsHE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1761603730; c=relaxed/simple; bh=FeG2i3JPg399NztbJdH/ulwpzbr5wLUMaRAZ7fG4f1A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=MlEcMCVLLl6/GD/A7LGxIzPZWZHGu7WHKNSTojjmxi9nWfufVnFGzGxWEP3RWocsbsasrHC+Q4m8xe7zB+HyFh47NbmMLrDEyubqMBai0s0tVxu2yRVc5J8uobunmWXXuX1oOh2NUSXyptpBp74dS3cLADne7FMNJ1Hfb1orgMs= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D76973858D20 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id DSRovgayVKXDJDVbOvUkjl; Mon, 27 Oct 2025 22:22:10 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id DVbNvKsp374Z0DVbNvlV4j; Mon, 27 Oct 2025 22:22:09 +0000 X-Authority-Analysis: v=2.4 cv=BuidwZX5 c=1 sm=1 tr=0 ts=68fff091 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=x6icFKpwvdMA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=h9jVOKsf90i8OGNVU3wA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=VS4QxaUSPT0UtbFnIvSC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=jE9Erw5bOPNOJ6NsEQWp4+h1mbip2/XpJkmKVkYZI7o=; b=coG2XLRKvTy/9KcmPcNQr22gsc 39T9ZBIAY4lC2uZ88H3w7aNZ2xGydWvnOzznmGYtzo8cutIxR7V/p0NdlKlnpap8h7J+UT5/i7GEo M7Lp4C+vGRISVy5+8XYVqQCpv; Received: from 97-122-110-68.hlrn.qwest.net ([97.122.110.68]:33062 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vDVbM-00000003CAt-41Yo; Mon, 27 Oct 2025 16:22:09 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv3 1/7] gdb: improve line number lookup around inline functions In-Reply-To: (Andrew Burgess's message of "Thu, 16 Oct 2025 18:49:47 +0100") References: X-Attribution: Tom Date: Mon, 27 Oct 2025 16:22:07 -0600 Message-ID: <87qzuo9e9c.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.68 X-Source-L: No X-Exim-ID: 1vDVbM-00000003CAt-41Yo X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-68.hlrn.qwest.net (prentzel) [97.122.110.68]:33062 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfI6v+IzFnMJPqmOUBdDdMHYkkNRMS3d8qzRw22qZ/knq6YQ812o2Px3T9ekqjooyFtb/bV+hUlaApU5ljyafIXvxuOZP9BcMn5c8K1dcDnSA0NuIuNXZ Lzfky8a2cRZFV8F2iLaJPaZtZpSJQy63jEK520Ov36CiO1uvJ5XU9p37Y/4PFgZDCI/l7JjNphnCLajSdLodiV71xmJBxy7OtEc= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> So my proposal is that the backward scan of the line table looking for Andrew> an is-stmt entry should not be performed when NOTCURRENT is true. In Andrew> the case above this means we will report the entry at index 9, which Andrew> is for line 10, which is correct. Thanks for the explanation. It all made sense to me. Andrew> + if ![runto foo] { We're bracing if conditions these days. Otherwise this looks good to me. Approved-By: Tom Tromey Tom