From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZPo7H/xOemkSLxoAWB0awg (envelope-from ) for ; Wed, 28 Jan 2026 13:01:32 -0500 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=uSUp7b+V; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 70E311E08D; Wed, 28 Jan 2026 13:01:32 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D9B861E08D for ; Wed, 28 Jan 2026 13:01:31 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 459B14BA9025 for ; Wed, 28 Jan 2026 18:01:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 459B14BA9025 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=uSUp7b+V Received: from omta38.uswest2.a.cloudfilter.net (omta38.uswest2.a.cloudfilter.net [35.89.44.37]) by sourceware.org (Postfix) with ESMTPS id EDF8B4BA2E3E for ; Wed, 28 Jan 2026 18:00:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDF8B4BA2E3E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EDF8B4BA2E3E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769623216; cv=none; b=oxG9WwgpMt4eMHL60/Iak4SgJD9t2b5FDFaXmoXeO2ZXcNMN3iEI8agFd+iHDviqLoGrG1ZbLZhLQ1hkzHoOb7kF2hj6jCBRW0GctjWlBo5ZD1VN+RylfHC7j/63TslFddjDr9GVxtgDctJLfrAe/+CBGFAgnRF9OV/08hc/K+o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1769623216; c=relaxed/simple; bh=hW2SqRwRhSA0bETue2a/dfyhJ41erQR+5KhxAviGC/c=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qZlbvQdjK6FU9FiLGF0G2Fx8HAIJfbMj5QpN6jFof77yGmZHiR90BLnFp+CAcRru7AiKCXeVi9phmgkOggRuKHtBDNiTQ/Xa72YRWj+yN3VHLQVd6sryA6mlMQQb4jGFxSi5GArlas5dXMHDVB57Z2aI5nOt36I4kYOruVFyjTI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EDF8B4BA2E3E Received: from eig-obgw-5007b.ext.cloudfilter.net ([10.0.29.167]) by cmsmtp with ESMTPS id l76YvqkxjipkCl9puv9c8p; Wed, 28 Jan 2026 18:00:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id l9ptvEvhCV6WMl9ptvG2lh; Wed, 28 Jan 2026 18:00:13 +0000 X-Authority-Analysis: v=2.4 cv=E//Npbdl c=1 sm=1 tr=0 ts=697a4eae a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=vUbySO9Y5rIA:10 a=ItBw4LHWJt0A:10 a=7CQSdrXTAAAA:8 a=GsjECv2lDElUJLfXXzAA:9 a=a-qgeE7W1pNrGK8U0ZQC:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=AYpw/+gks1KGocryQmL8ysJzN6QqQIC+Hz93UxJcyVw=; b=uSUp7b+V1lcBz/g0JMopBL0wIG FbriXC6QYs4cQLvCKyneWp5F0rAwYUrlhCDE1G7MRUk87ig0YGg6IP5vMiZpOuMelqYi9d6HkTcNc tyghKfTT2LugUDOCU9iCJPbtT; Received: from 97-122-114-32.hlrn.qwest.net ([97.122.114.32]:34956 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1vl9pt-00000000b4r-0IWm; Wed, 28 Jan 2026 11:00:13 -0700 From: Tom Tromey To: Matthieu Longo Cc: , Tom Tromey Subject: Re: [PATCH v2 4/6] gdb: new setters and getters for __dict__, and attributes In-Reply-To: <20260128120239.1959325-1-matthieu.longo@arm.com> (Matthieu Longo's message of "Wed, 28 Jan 2026 12:02:39 +0000") References: <20260128120239.1959325-1-matthieu.longo@arm.com> X-Attribution: Tom Date: Wed, 28 Jan 2026 11:00:11 -0700 Message-ID: <87qzr98vo4.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.114.32 X-Source-L: No X-Exim-ID: 1vl9pt-00000000b4r-0IWm X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-114-32.hlrn.qwest.net (bapiya) [97.122.114.32]:34956 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfN9VPH5TuZXLudXPw3sbAz6noYc7HBJ0Xeubr7szvP07Fpcjm42nw0/9bO3lkb74IEOHZ4LtEu2jsVSmEW7wzl1h3RL1ZK72j76N/+Vpjm6KgJnlLHCb pFnf9Zbv9OF3vZEwFrRSCDpO+fwMuUsTp9h1D58MeeHBgf2eFSRHPPXHOAglmFScOw0aSY5pWtUYh6O+ePqWXFVayaxEK2D46Lk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Matthieu" == Matthieu Longo writes: Matthieu> GDB is currently using the Python unlimited API. Migrating the codebase Matthieu> to the Python limited API would have for benefit to make a GDB build Matthieu> artifacts compatible with older and newer versions of Python that they Matthieu> were built with. Thanks again. Matthieu> + value = PyDict_GetItemWithError (dict.get (), attr); Matthieu> + if (value != nullptr) Matthieu> + return Py_NewRef (value); Matthieu> + Matthieu> + /* PyDict_GetItemWithError() has a misleading name that lets one believe that Matthieu> + the function sets PyExc_AttributeError when the key is not found, whereas Matthieu> + it actually does not and only returns NULL. Matthieu> + Not setting the exception for an unfound key causes the raising of another Matthieu> + exception: Matthieu> + : error return without exception set Matthieu> + Hence this surprising manual setting of an exception to makes everything Matthieu> + fit into place. */ Matthieu> + PyErr_Format (PyExc_AttributeError, Matthieu> + "'%s' object has no attribute '%s'", Matthieu> + Py_TYPE (self)->tp_name, Matthieu> + PyUnicode_AsUTF8AndSize (attr, nullptr)); It seems to me that there should be an additional check between the call to PyDict_GetItemWithError and PyErr_Format, like: if (PyErr_Occurred () != nullptr) return nullptr; Since according to the PyDict_GetItemWithError docs, this function can return null with the error set. With that change the comment could probably be shortened a bit since it's no longer surprising to have to set the exception. Tom