From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/3] [gdb/contrib] Some dwarf-to-dwarf-assember.py fixes
Date: Mon, 09 Mar 2026 08:10:56 -0600 [thread overview]
Message-ID: <87qzptw0sv.fsf@tromey.com> (raw)
In-Reply-To: <20260309121930.3098744-1-tdevries@suse.de> (Tom de Vries's message of "Mon, 9 Mar 2026 13:19:27 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> I ran into trouble using dwarf-to-dwarf-assember.py on a hello world
Tom> executable, due to DW_LANG_MIPS_assembler.
Tom> The first patch fixes this.
Tom> I then tested the script on the executables generated by the testsuite, and ran into
Tom> DW_FORM_data16 being unsupported.
Tom> The second patch fixes that.
Tom> The third patch removes the only raise from the script, preferring imperfect
Tom> to partial output.
This all seems reasonable to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2026-03-09 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 12:19 Tom de Vries
2026-03-09 12:19 ` [PATCH 1/3] [gdb/contrib] Handle DW_LANG_Mips_Assembler in dwarf-to-dwarf-assembler.py Tom de Vries
2026-03-09 14:10 ` Tom Tromey
2026-03-09 15:25 ` Tom de Vries
2026-03-09 12:19 ` [PATCH 2/3] [gdb/contrib] Handle DW_FORM_data16 " Tom de Vries
2026-03-09 12:19 ` [PATCH 3/3] [gdb/contrib] Avoid NotImplementedError " Tom de Vries
2026-03-09 14:10 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qzptw0sv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox