From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oD+qE8FVtGn14ScAWB0awg (envelope-from ) for ; Fri, 13 Mar 2026 14:21:53 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DMNzSyZZ; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3B6991E089; Fri, 13 Mar 2026 14:21:53 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9601B1E089 for ; Fri, 13 Mar 2026 14:21:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 0803C4BCA418 for ; Fri, 13 Mar 2026 18:21:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0803C4BCA418 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=DMNzSyZZ Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 733384BC89A3 for ; Fri, 13 Mar 2026 18:21:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 733384BC89A3 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 733384BC89A3 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773426075; cv=none; b=TdgDR0SFmk7B1N0QXYrmkz3YurPmmql0BX+w6G722vf4tquVkv1o19SC81kAcPw9ZzJp0P29twsC71GUmXP+PQnLbCOOF0QwtY8NkGJjvxiQ8sHUJbxWk+5hshWvSMaxyGqCV6UF1Z3sqIK+sbFmhIhtr7r3R8VB3beroPiiwVA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1773426075; c=relaxed/simple; bh=ftNs0CKY+z+xiQZiPSGTXq+ANUx941OhwAi0Q+DXF6M=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WwvrlAvYMgkLVUFsC4+iZmyWz5/QAB9YOjzBiWvHN2uiXOHo7SqMrIfdO7NS1v1cwvjZTPHOp10ge9qA0ddG8UnCkxKUr57xUQgz3Zqu5kJi6aJuNUECBDyL+6pVTH/jskBo3qDnGrDFfcF5+z9/TCyXMmWcDLrvx1vIp6yM14I= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 733384BC89A3 Received: from eig-obgw-6006b.ext.cloudfilter.net ([10.0.30.211]) by cmsmtp with ESMTPS id 133cwgxr0KXDJ178Nws67B; Fri, 13 Mar 2026 18:21:15 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id 178Kw1NBYvXvH178KwEaQ8; Fri, 13 Mar 2026 18:21:12 +0000 X-Authority-Analysis: v=2.4 cv=e4IGSbp/ c=1 sm=1 tr=0 ts=69b4559a a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Yq5XynenixoA:10 a=ItBw4LHWJt0A:10 a=_ZhYKdCeAAAA:8 a=zstS-IiYAAAA:8 a=V6UIkqdmlt9r6HhEJGMA:9 a=uqOk3ZSnBfCTOznnrPA1:22 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ve8nEhaD6SQSi/n5zKDvs+6Y5ivnZRqpVxpL12son84=; b=DMNzSyZZ38MbEicoHnIsyqW3wj NhR+hAFqm+kLkO4NZyejKc9xlf1B4TzUr3gktaRMdZvnsdhv0ikv8yHnJAl3Twpb61PIGczGk15Wo tcOoPo9tbsxrt7yV+p4rLIO59; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:49624 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1w178J-00000000UM5-3iQh; Fri, 13 Mar 2026 12:21:11 -0600 From: Tom Tromey To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/5] gdb/linux-tdep: check return value of linux_find_memory_region_ftype callback In-Reply-To: <20260310173104.676640-1-simon.marchi@polymtl.ca> (simon marchi's message of "Tue, 10 Mar 2026 13:30:32 -0400") References: <20260310173104.676640-1-simon.marchi@polymtl.ca> X-Attribution: Tom Date: Fri, 13 Mar 2026 12:21:10 -0600 Message-ID: <87qzpnr3op.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1w178J-00000000UM5-3iQh X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:49624 X-Source-Auth: tom+tromey.com X-Email-Count: 6 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfCT2vz940SwY9wlPNlJrjGrgjmxDG2E8NSiryQhmUqpYIkgUvwBs46TUv4hdfHlu3ZSdiHSeQBD0QbMEiNR8ykQ/v2m4EZlZutwLy5sJiap/FUL5kSMl hge/v5Sa2w82i0NUPrTrVgAYQGGRuQWdxHSsso/l/pxbwAMcKL3CDWtyilyFqkUl50jH/545tSr8zA2s1AWR1DLx9Fk0cstnoTQ= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Simon" == simon marchi writes: Simon> From: Simon Marchi Simon> I noticed that linux_find_memory_regions_full did not check the return Simon> value of the linux_find_memory_region_ftype callback. I think this is a Simon> mistake. When called from linux_find_memory_regions, the Simon> find_memory_region_ftype callback could return false, in which case we Simon> should stop iterating. Simon> This probably didn't matter in practice, as these callbacks generally Simon> don't return false (only in error cases that never happen). Looks reasonable. Approved-By: Tom Tromey Tom