From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3m8OFnIV4mmtRB4AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 07:11:46 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BG/eI9Jt; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 463AD1E0B1; Fri, 17 Apr 2026 07:11:46 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 967FA1E0B1 for ; Fri, 17 Apr 2026 07:11:45 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8AD554BB3BC3 for ; Fri, 17 Apr 2026 11:11:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8AD554BB3BC3 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BG/eI9Jt Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 450D34BA2E35 for ; Fri, 17 Apr 2026 11:11:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 450D34BA2E35 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 450D34BA2E35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776424278; cv=none; b=RX9mc9fctwvNSbADy4Hd3hlpXULvScwd6CZdrnv7cR/UjdzI7E+U2wYJCuSw8G3wfZ8KwV0uxVPX6vsAo/L6QNdv4l0Gq+trrystuYhLDrHu+RnzpJrfbKW6+dd0W6PD6m+LBs+BVcF4GN4h3KKnylNP2vnxfO3JyRFaIlUscXY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776424278; c=relaxed/simple; bh=zYKXX4qs46eJYFGHnWYXtnCDQeB37JF216qK3HJtcOw=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=VDKXbnv/AI8jfnxg40ihod+ZrLvm7UytUzlRXgZ8QV7PPP1kmVBHlRydUuVB4JUbGjI3AC0HRu1HvQbzamXoj8Zs8h4TGksnfJ2BmNvbi8587EOvDRR0JfSb5muBGkobkVR416cTQu99YDTI7FtnmJBt5/5vP1n1hiuPqZKrgo8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 450D34BA2E35 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776424277; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xRme9SIEzpCw+2C89lhpXZGeQ1PUPepEeJV22Zgx4KU=; b=BG/eI9JtwVSs7igDH04pRv6lys1YyBcNw3EWPR/dHh+wtxCwoK00urLJxiVpqNj2tBiLkY /8OJcIVOZ2VHKlMK5vfFtAEIn1GsYujL++QJq87CxhCqB66c1moyCJyxJEFpIw2RUNkq8Q xRs7zS1fWzfnvEqNyxbr6CqFuPwO++A= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-288-IPbcjQ19PS-AIslL7XvrEQ-1; Fri, 17 Apr 2026 07:11:16 -0400 X-MC-Unique: IPbcjQ19PS-AIslL7XvrEQ-1 X-Mimecast-MFC-AGG-ID: IPbcjQ19PS-AIslL7XvrEQ_1776424275 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-488dcaf2f2fso4112165e9.0 for ; Fri, 17 Apr 2026 04:11:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776424275; x=1777029075; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=xRme9SIEzpCw+2C89lhpXZGeQ1PUPepEeJV22Zgx4KU=; b=ODsL7BlRdTYMDG05Fdp0SnnCrsL+wCKJq5E/8VoP+s6N2u95vN8m2zGipjgF1QebOR +KGfn1atiK55/GxWHQujZE+2jZFe6pnVQi1y6nvY2emXsFidZEgv47q51ssX0R8bH6TY oG1fFM5qBHjMYLz9iZgYYMjqkKcInk3Kn8hpfLyFLgSf+9boK4At+HxhYkRlrgsR6Kvn PJ8U2b5QwvlKRQK+lDyOkG6SuBtmgj0OEBpkF4nHBoXt2tee5YQsWyZXXytTsTWx68C9 s0e9HFLpPGJQGtHzj+1qbqY30VX3h2GZCotOPEf1+MhzjWpJdObt6l7XsBazSo+MkCK7 22nQ== X-Forwarded-Encrypted: i=1; AFNElJ98m95X38kQc8L4kHLMM/XazHni+hmg77HmwlMJ1luMY9CB6z4XIkM9qyIcGZuCeDEpRgelbnsLV+M2Hg==@sourceware.org X-Gm-Message-State: AOJu0Yy/knswR6hi3s3FXMkhTKGPNv686aLB278TugzTIT5WghKA4LYn jbiiF4WOfYB3/CCdg3VLG00fQfvR1jNSUDVe+SZcmXbIv3MbIPBRIbLwWEBOTFm9csaYuVoo+Ki idjmO0dOBbx4K8ax4PXd8fgTF0i5P8SlaX5gSc6/BLzVUd7vI5gGWmXOA3e1xmUM= X-Gm-Gg: AeBDietai/weRGK/ijlHfT8r2yKGVHVNruYQHszHxut1+GzR9wRemISGhdX3covLDCY RhVnBULdD27Aoj0mTd+ZMCMWD5hWWgzIuoPYcOSp3fiERL8+2mGxbXPv/v6B7GhAg/pwu4NCRzH DMgi8pXbA5N/d6F0vkjWxYtkjahGXfiRgckbO+9FhZ0G1T4MMRFpDGMpgqkMHn30XDY46L78QH7 bQwS1myliIvHvlJyWjONPIFvLL14xaQx+xRDXfy9t7c+nHdOUXLre+HZdC2LJ9gLTkw+eBhxHEn o6away2RUltCJuKwnZgRgesFRGpjVXosB8+r4+A3T/eMRZ+8VHy3zz+h4Y3eFScxSCbdUcQPKBg f9ClAdha8wbnn9mXgm8L0E67acLs= X-Received: by 2002:a05:600c:4e4f:b0:488:d6eb:e63c with SMTP id 5b1f17b1804b1-488fb778703mr35025915e9.15.1776424274865; Fri, 17 Apr 2026 04:11:14 -0700 (PDT) X-Received: by 2002:a05:600c:4e4f:b0:488:d6eb:e63c with SMTP id 5b1f17b1804b1-488fb778703mr35025485e9.15.1776424274408; Fri, 17 Apr 2026 04:11:14 -0700 (PDT) Received: from localhost ([31.111.84.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488fc1393d3sm57849865e9.11.2026.04.17.04.11.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Apr 2026 04:11:13 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Cc: Simon Marchi Subject: Re: [PATCH 01/11] gdb/dwarf: remove unused file_match parameter from dwarf2_base_index_functions::search_one In-Reply-To: <20260416202408.422441-2-simon.marchi@efficios.com> References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-2-simon.marchi@efficios.com> Date: Fri, 17 Apr 2026 12:11:13 +0100 Message-ID: <87qzodet9q.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SaO_1gNiXk8geS1Hm7GykJQ-hZJJ_KPwGApN_p5X0TM_1776424275 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > The `file_matcher` parameter is unused. > > The information from `file_matcher` is actually encoded in > `cus_to_skip`. All callers to this: > > auto_bool_vector cus_to_skip; > dw_search_file_matcher (per_objfile, cus_to_skip, file_matcher); > > ... which populates `cus_to_skip` with all the CUs that do not match > `file_matcher`. LGTM. Approved-By: Andrew Burgess Thanks, Andrew > > Change-Id: I7fd642f84d72ad2595c1e6de38db3869cc555ce9 > --- > gdb/dwarf2/read.c | 13 ++++++------- > gdb/dwarf2/read.h | 6 +++--- > 2 files changed, 9 insertions(+), 10 deletions(-) > > diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c > index 4035bba6e45b..02e6c00dfef5 100644 > --- a/gdb/dwarf2/read.c > +++ b/gdb/dwarf2/read.c > @@ -1480,8 +1480,8 @@ struct readnow_functions : public dwarf2_base_index_functions > || per_cu->unit_type (false) == 0 > || per_objfile->get_compunit_symtab (per_cu.get ()) == nullptr) > continue; > - if (!search_one (per_cu.get (), per_objfile, cus_to_skip, file_matcher, > - listener, lang_matcher)) > + if (!search_one (per_cu.get (), per_objfile, cus_to_skip, listener, > + lang_matcher)) > return false; > } > return true; > @@ -1923,7 +1923,6 @@ dwarf2_base_index_functions::search_one > (dwarf2_per_cu *per_cu, > dwarf2_per_objfile *per_objfile, > auto_bool_vector &cus_to_skip, > - search_symtabs_file_matcher file_matcher, > search_symtabs_expansion_listener listener, > search_symtabs_lang_matcher lang_matcher) > { > @@ -14056,8 +14055,8 @@ cooked_index_functions::search > { > QUIT; > > - if (!search_one (per_cu, per_objfile, cus_to_skip, file_matcher, > - listener, lang_matcher)) > + if (!search_one (per_cu, per_objfile, cus_to_skip, listener, > + lang_matcher)) > return false; > } > return true; > @@ -14224,8 +14223,8 @@ cooked_index_functions::search > > bool check = entry->visit_defining_cus ([&] (dwarf2_per_cu *per_cu) > { > - return search_one (per_cu, per_objfile, cus_to_skip, > - file_matcher, listener, nullptr); > + return search_one (per_cu, per_objfile, cus_to_skip, listener, > + nullptr); > }); > if (!check) > return false; > diff --git a/gdb/dwarf2/read.h b/gdb/dwarf2/read.h > index 1150c3cfdcad..fddaaa7d9e5c 100644 > --- a/gdb/dwarf2/read.h > +++ b/gdb/dwarf2/read.h > @@ -1318,11 +1318,11 @@ struct dwarf2_base_index_functions : public quick_symbol_functions > bool need_fullname) override; > > protected: > - /* If FILE_MATCHER is NULL and if CUS_TO_SKIP does not include the CU's index, > - expand the CU and call LISTENER on it. */ > + /* If CUS_TO_SKIP does not include the CU's index and the CU's language > + matches LANG_MATCHER, expand the CU and call LISTENER (if provided) on > + it. */ > bool search_one (dwarf2_per_cu *per_cu, dwarf2_per_objfile *per_objfile, > auto_bool_vector &cus_to_skip, > - search_symtabs_file_matcher file_matcher, > search_symtabs_expansion_listener listener, > search_symtabs_lang_matcher lang_matcher); > }; > -- > 2.53.0