Re: [PATCH v2 1/2] [gdb/python] Introduce py_none/py_true/py_false functions

[Tom Tromey <tom@tromey.com>]

>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> +/* The following three functions are refcount-safe wrappers around
Tom> +   Py_RETURN_{NONE,TRUE,FALSE}.  Starting with python 3.12, None, True and
Tom> +   False are immortal, and increasing and decreasing refcount for such object
Tom> +   is a no-op, but while supporting older versions we ignore that aspect
Tom> +   here.  */

This comment is mildly incorrect in that using gdbpy_ref<> inherently
implies a decref.  Immortality of Python objects isn't really a concern
at the API level.  It's an implementation detail of the Python
interpreter.

The rest of the patch seems ok to me.  I'm not a huge fan of
immediately-evaluated lambdas but OTOH it's probably harmless here.

    +  return gdbpy_ref<> ([] { Py_RETURN_FALSE; } ());
    +}
     #endif /* GDB_PYTHON_PYTHON_INTERNAL_H */

Newline between the closing brace and the #endif please.

thanks,
Tom