From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GfifHWm1GWqkNScAWB0awg (envelope-from ) for ; Fri, 29 May 2026 11:48:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E+nBQbIf; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7437B1E0A3; Fri, 29 May 2026 11:48:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8D53E1E062 for ; Fri, 29 May 2026 11:48:56 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 140634BA23DB for ; Fri, 29 May 2026 15:48:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 140634BA23DB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E+nBQbIf Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 342044BA2E0F for ; Fri, 29 May 2026 15:48:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 342044BA2E0F Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 342044BA2E0F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780069709; cv=none; b=uqf05z1QpE/DaFewA1WQYZ6FGUJxm6XkCXID4Gaxoby+T7jlAK3oG5RckZr4Op2ouCdhZA3MIttoaYQA95oEw0Y0KfTAI3iJ7ju9zW/yic8FwRffIsfjWEzH1qe6pzjEVik7hhfr10IfKI9z6CmDPlY3q7KMBIOtbxFP8P/9SOY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1780069709; c=relaxed/simple; bh=yEq6edjKaBxmWFOxh4iZwZovq2GYN/SXGjSf2JBsF2I=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=tmYhSHnT/AVsUrggK8ZX8d3meIGKFDPmjMJYyRymjH3N3e5NKWThqC2iOzOqvCoQnC0GHsfFpUUQ4moxDXs+ACfURvWwjhwrzUMLUsxq4t2PqWz3wcOM7bmVJGef2BB4sUINE1sUuaOFNsTSuFZSumuhMYy6muL6DmtZiYOKG9Y= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=E+nBQbIf DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 342044BA2E0F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1780069708; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=V9Wxc4HQRabL5YZOIDKS8sCvuKSukLuYyhF9vlZuUOY=; b=E+nBQbIfT6VoMzCZOyqiqyvL9EmkMKi26EpYXO9cNQuaQnlIktYER2MFdlEVZoISzXVUl+ 8q7lCrOwLdT2+NuJW9AOMqwIcgs9w4zc6hMNTVJ/aUJVfcN6lhRS+YgH5PfEHPI/GuVXjk vtXHeOqwX2Cv81rBJajIUCaFFk5O7oY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-ZfKc3mkaMMaDR2J4BFWltA-1; Fri, 29 May 2026 11:48:27 -0400 X-MC-Unique: ZfKc3mkaMMaDR2J4BFWltA-1 X-Mimecast-MFC-AGG-ID: ZfKc3mkaMMaDR2J4BFWltA_1780069706 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-45ef5ba50aeso281806f8f.0 for ; Fri, 29 May 2026 08:48:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780069706; x=1780674506; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=V9Wxc4HQRabL5YZOIDKS8sCvuKSukLuYyhF9vlZuUOY=; b=HzaQhhz1acRpWPn/DJ8ilIKXF4S0AgrLqE+bwSWyxWT9Rg+DEoHuNOK9UpavPZKt8O f2B8GeISHFz0TGoN0jCy0E/GA2iAdriN8VKHyWUsWJu1d8wsZpZca7eaPJ6K/9Z4SoZb iHimpNFPtpYB2zd/0TmXbmbTusmLujmL1JNdpz8IyVJtHRawTF6QE9PaGKgmVhBomA5m dFRWM19Bh3AG/rxzPvhhk9FuX/2rv+AxGO1EiuVP5eWZ5IZLxCy0OjNfIPhe5s0v0ebg FJn6k02Ut1VY4TqVGm2iXrVbuqAOGhXKObDTJ0xg9QVUVr932iQ3WohB6RKMV1NIV8ex 4vvg== X-Forwarded-Encrypted: i=1; AFNElJ+dLT82Flvdl25MfFGTaw3FB+Fq1JuuoMRVvv43RVYW5fxHQoEJVbexapxH2gY8SbqzoyyD/LCeTopb6A==@sourceware.org X-Gm-Message-State: AOJu0YwBzQG3dYW7J22M6p6kbHTbq2BDx2Cy3B+IhMzDTcunsHBwqHrS NZ+/YA2hBn9Am2WEohDnf/gDaU5KR/d+Wx2nw38u9wALopMh5Wl+prD31/xZSiGNOS5K00278qf +/cLad4e+a0R+L4i6mgcXLsm9CXX5twswtC+DSjIjXbU3+/SLe03mEFsVXItOXG14seIqlaY= X-Gm-Gg: Acq92OEDUCtp9Qej5ItnOI/ueHD5LuCaqQHYOmuHXzS/+9lC0cVfBe+wlCpNWZ2q7Bz /vf/Ryjk6YUjDq6M/aSXkZZSsOXE4MhNFQo53XNGtuvCXJfcGTy6C9R2+S7akqnQboyxMfBxpAH jDs9m3Yc/B/0PYu83cw/DiJcAkiu7RQJYb6jtrjzcrh7rD2zfteIGzC0W9TGk4tStkGOaexv85q NVkV/e+nfNE8pIe/dt3lGpEjrUPRauaohT9wFoIfBjGUf9erGc9A5a4armO8ost9bvMCgDmPFGc gXLbgy2BQii0+7YK9vFpPBr5FAE2xMnXZHBfS713Vhp8buTB/96+IpWvlqvHO6dLIbeYte29LNJ pAtXB1NEUUw5Cl4T0Q4w+Fq1sAg== X-Received: by 2002:a5d:6d43:0:b0:43d:e31:68d1 with SMTP id ffacd0b85a97d-45ef6b5fe99mr518381f8f.21.1780069705756; Fri, 29 May 2026 08:48:25 -0700 (PDT) X-Received: by 2002:a5d:6d43:0:b0:43d:e31:68d1 with SMTP id ffacd0b85a97d-45ef6b5fe99mr518327f8f.21.1780069705154; Fri, 29 May 2026 08:48:25 -0700 (PDT) Received: from localhost ([213.31.44.43]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34a037fsm4374179f8f.4.2026.05.29.08.48.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 May 2026 08:48:24 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , gdb-patches@sourceware.org Cc: Tom Tromey Subject: Re: [PATCH] Do not use ENUM_BITFIELD In-Reply-To: <20260524202940.1870575-1-tom@tromey.com> References: <20260524202940.1870575-1-tom@tromey.com> Date: Fri, 29 May 2026 16:48:24 +0100 Message-ID: <87qzmuxlmf.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: siQNAdSspfWlZ7H_fJtW5lvSkaczq7DCdKcEuODKU6g_1780069706 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Tom Tromey writes: > C++ always allows enum bitfields, so gdb no longer needs to use the > ENUM_BITFIELD macro. > > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=32821 LGTM. Approved-By: Andrew Burgess Thanks, Andrew > --- > gdb/cli/cli-decode.h | 2 +- > gdb/dwarf2/abbrev.h | 6 +++--- > gdb/dwarf2/attribute.h | 4 ++-- > gdb/dwarf2/call-site.h | 2 +- > gdb/dwarf2/cooked-index-entry.h | 2 +- > gdb/dwarf2/die.h | 2 +- > gdb/frame-id.h | 2 +- > gdb/gdbtypes.h | 14 +++++++------- > gdb/macrotab.h | 2 +- > gdb/symtab.h | 12 ++++++------ > gdbsupport/packed.h | 4 ++-- > 11 files changed, 26 insertions(+), 26 deletions(-) > > diff --git a/gdb/cli/cli-decode.h b/gdb/cli/cli-decode.h > index 865f89ed9b5..49384f4a04d 100644 > --- a/gdb/cli/cli-decode.h > +++ b/gdb/cli/cli-decode.h > @@ -177,7 +177,7 @@ struct cmd_list_element > > /* Type of "set" or "show" command (or SET_NOT_SET if not "set" > or "show"). */ > - ENUM_BITFIELD (cmd_types) type : 2; > + cmd_types type : 2; > > /* Function definition of this command. NULL for command class > names and for help topics that are not really commands. NOTE: > diff --git a/gdb/dwarf2/abbrev.h b/gdb/dwarf2/abbrev.h > index c5a3c6c39a6..78ad1e164ad 100644 > --- a/gdb/dwarf2/abbrev.h > +++ b/gdb/dwarf2/abbrev.h > @@ -34,8 +34,8 @@ > > struct attr_abbrev > { > - ENUM_BITFIELD(dwarf_attribute) name : 16; > - ENUM_BITFIELD(dwarf_form) form : 16; > + dwarf_attribute name : 16; > + dwarf_form form : 16; > > /* It is valid only if FORM is DW_FORM_implicit_const. */ > LONGEST implicit_const; > @@ -47,7 +47,7 @@ struct abbrev_info > /* Number identifying abbrev. */ > unsigned int number; > /* DWARF tag. */ > - ENUM_BITFIELD (dwarf_tag) tag : 16; > + dwarf_tag tag : 16; > /* True if the DIE has children. */ > bool has_children; > bool interesting; > diff --git a/gdb/dwarf2/attribute.h b/gdb/dwarf2/attribute.h > index 776ce43825d..f2648747d9c 100644 > --- a/gdb/dwarf2/attribute.h > +++ b/gdb/dwarf2/attribute.h > @@ -338,7 +338,7 @@ struct attribute > will issue a complaint and return false. */ > bool as_boolean () const; > > - ENUM_BITFIELD(dwarf_attribute) name : 15; > + dwarf_attribute name : 15; > > /* A boolean that is used for forms that require reprocessing. A > form may require data not directly available in the attribute. > @@ -351,7 +351,7 @@ struct attribute > forms. */ > unsigned int requires_reprocessing : 1; > > - ENUM_BITFIELD(dwarf_form) form : 15; > + dwarf_form form : 15; > > /* Has u.str already been updated by dwarf2_canonicalize_name? This > field should be in u.str but it is kept here for better struct > diff --git a/gdb/dwarf2/call-site.h b/gdb/dwarf2/call-site.h > index e5519721390..5e2e270e383 100644 > --- a/gdb/dwarf2/call-site.h > +++ b/gdb/dwarf2/call-site.h > @@ -152,7 +152,7 @@ struct call_site_parameter > gdb::array_view data_value_expr () const > { return gdb::make_array_view (data_value, data_value_size); } > > - ENUM_BITFIELD (call_site_parameter_kind) kind : 2; > + call_site_parameter_kind kind : 2; > > union call_site_parameter_u u; > > diff --git a/gdb/dwarf2/cooked-index-entry.h b/gdb/dwarf2/cooked-index-entry.h > index 9f7a7c42de4..60ea581cbbe 100644 > --- a/gdb/dwarf2/cooked-index-entry.h > +++ b/gdb/dwarf2/cooked-index-entry.h > @@ -267,7 +267,7 @@ struct cooked_index_entry : public allocate_on_obstack > situation where the language is initially unknown, and then only > filled in later. In particular this can happen when using > .gdb_index. See also cooked_index_functions::search. */ > - mutable ENUM_BITFIELD (language) lang : LANGUAGE_BITS; > + mutable language lang : LANGUAGE_BITS; > /* The offset of this DIE. */ > sect_offset die_offset; > /* The CU from which this entry originates. This may point to a > diff --git a/gdb/dwarf2/die.h b/gdb/dwarf2/die.h > index c5f8a8e89f1..a8bc147b1c8 100644 > --- a/gdb/dwarf2/die.h > +++ b/gdb/dwarf2/die.h > @@ -114,7 +114,7 @@ struct die_info > } > > /* DWARF-2 tag for this DIE. */ > - ENUM_BITFIELD(dwarf_tag) tag : 16; > + dwarf_tag tag : 16; > > /* Number of attributes */ > unsigned char num_attrs; > diff --git a/gdb/frame-id.h b/gdb/frame-id.h > index 50de31133a6..677b159b26b 100644 > --- a/gdb/frame-id.h > +++ b/gdb/frame-id.h > @@ -95,7 +95,7 @@ struct frame_id > CORE_ADDR special_addr; > > /* Flags to indicate the above fields have valid contents. */ > - ENUM_BITFIELD(frame_id_stack_status) stack_status : 3; > + frame_id_stack_status stack_status : 3; > unsigned int code_addr_p : 1; > unsigned int special_addr_p : 1; > > diff --git a/gdb/gdbtypes.h b/gdb/gdbtypes.h > index b32056ce530..027b814fe6a 100644 > --- a/gdb/gdbtypes.h > +++ b/gdb/gdbtypes.h > @@ -756,7 +756,7 @@ struct field > > /* * Discriminant for union field_location. */ > > - ENUM_BITFIELD(field_loc_kind) m_loc_kind : 3; > + field_loc_kind m_loc_kind : 3; > > /* Accessibility of the field. */ > enum accessibility m_accessibility; > @@ -902,7 +902,7 @@ struct main_type > { > /* * Code for kind of type. */ > > - ENUM_BITFIELD(type_code) code : 8; > + type_code code : 8; > > /* * Flags about this type. These fields appear at this location > because they packs nicely here. See the TYPE_* macros for > @@ -942,11 +942,11 @@ struct main_type > /* * A discriminant telling us which field of the type_specific > union is being used for this type, if any. */ > > - ENUM_BITFIELD(type_specific_kind) type_specific_field : 3; > + type_specific_kind type_specific_field : 3; > > /* The language for this type. */ > > - ENUM_BITFIELD(language) m_lang : LANGUAGE_BITS; > + language m_lang : LANGUAGE_BITS; > > /* * Number of fields described for this type. This field appears > at this location because it packs nicely here. */ > @@ -1667,7 +1667,7 @@ struct fn_field > /* * DW_AT_defaulted attribute for this function. The value is one > of the DW_DEFAULTED constants. */ > > - ENUM_BITFIELD (dwarf_defaulted_attribute) defaulted : 2; > + dwarf_defaulted_attribute defaulted : 2; > > /* Accessibility of the field. */ > enum accessibility accessibility; > @@ -1745,7 +1745,7 @@ struct cplus_struct_type > DW_AT_calling_convention attribute. The value is one of the > DW_CC constants. */ > > - ENUM_BITFIELD (dwarf_calling_convention) calling_convention : 8; > + dwarf_calling_convention calling_convention : 8; > > /* * The base class which defined the virtual function table pointer. */ > > @@ -1821,7 +1821,7 @@ struct func_type > DW_AT_calling_convention attribute. The value is one of the > DW_CC constants. */ > > - ENUM_BITFIELD (dwarf_calling_convention) calling_convention : 8; > + dwarf_calling_convention calling_convention : 8; > > /* * Whether this function normally returns to its caller. It is > set from the DW_AT_noreturn attribute if set on the > diff --git a/gdb/macrotab.h b/gdb/macrotab.h > index 4e66c7ac915..1a4c46a1cb1 100644 > --- a/gdb/macrotab.h > +++ b/gdb/macrotab.h > @@ -291,7 +291,7 @@ struct macro_definition > struct macro_table *table; > > /* What kind of macro it is. */ > - ENUM_BITFIELD (macro_kind) kind : 1; > + macro_kind kind : 1; > > /* If `kind' is `macro_function_like', the number of arguments it > takes, and their names. The names, and the array of pointers to > diff --git a/gdb/symtab.h b/gdb/symtab.h > index 5a3db47d84f..0a7ad3668b4 100644 > --- a/gdb/symtab.h > +++ b/gdb/symtab.h > @@ -404,11 +404,11 @@ typedef bool (symbol_name_matcher_ftype) > struct partial_symbol > > These structures are laid out to encourage good packing. > - They use ENUM_BITFIELD and short int fields, and they order the > + They use bitfields and short int fields, and they order the > structure members so that fields less than a word are next > to each other so they can be packed together. */ > > -/* Rearranged: used ENUM_BITFIELD and rearranged field order in > +/* Rearranged: used bitfields and rearranged field order in > all the space critical structures (plus struct minimal_symbol). > Memory usage dropped from 99360768 bytes to 90001408 bytes. > I measured this with before-and-after tests of > @@ -586,7 +586,7 @@ struct general_symbol_info > This is used to select one of the fields from the language specific > union above. */ > > - ENUM_BITFIELD(language) m_language : LANGUAGE_BITS; > + enum language m_language : LANGUAGE_BITS; > > /* This is only used by Ada. If set, then the 'demangled_name' field > of language_specific is valid. Otherwise, the 'obstack' field is > @@ -815,7 +815,7 @@ struct minimal_symbol : public general_symbol_info > > /* Classification type for this minimal symbol. */ > > - ENUM_BITFIELD(minimal_symbol_type) m_type : MINSYM_TYPE_BITS; > + minimal_symbol_type m_type : MINSYM_TYPE_BITS; > > /* Non-zero if this symbol was created by gdb. > Such symbols do not appear in the output of "info var|fun". */ > @@ -1468,7 +1468,7 @@ struct symbol : public general_symbol_info, public allocate_on_obstack > > /* Domain code. */ > > - ENUM_BITFIELD(domain_enum) m_domain : SYMBOL_DOMAIN_BITS; > + domain_enum m_domain : SYMBOL_DOMAIN_BITS; > > /* Location class. This holds an index into the 'symbol_impls' > table. The actual location_class value is stored there, > @@ -1498,7 +1498,7 @@ struct symbol : public general_symbol_info, public allocate_on_obstack > > /* The concrete type of this symbol. */ > > - ENUM_BITFIELD (symbol_subclass_kind) subclass : 2; > + symbol_subclass_kind subclass : 2; > > /* Whether this symbol is artificial. */ > > diff --git a/gdbsupport/packed.h b/gdbsupport/packed.h > index 16564d5312e..70ffb712e19 100644 > --- a/gdbsupport/packed.h > +++ b/gdbsupport/packed.h > @@ -25,8 +25,8 @@ > defines a type that behaves like a given scalar type, but that has > byte alignment, and, may optionally have a smaller size than the > given scalar type. This is typically used as alternative to > - bit-fields (and ENUM_BITFIELD), when the fields must have separate > - memory locations to avoid data races. */ > + bit-fields, when the fields must have separate memory locations to > + avoid data races. */ > > /* There are two implementations here -- one standard compliant, using > a byte array for internal representation, and another that relies > -- > 2.49.0