From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EWF/BTFmOmrevxQAWB0awg (envelope-from ) for ; Tue, 23 Jun 2026 06:55:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WDVux+5r; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 12C421E024; Tue, 23 Jun 2026 06:55:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B7F371E024 for ; Tue, 23 Jun 2026 06:55:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B52C14BA5435 for ; Tue, 23 Jun 2026 10:55:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B52C14BA5435 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WDVux+5r Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 984274BA23C4 for ; Tue, 23 Jun 2026 10:55:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 984274BA23C4 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 984274BA23C4 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782212119; cv=none; b=Sg/hOBjw1kV0XtF8cOY4doBIgVaYWm6RZkiegINKtEPrYUNb/F7WkcabUjPcoCVrgwpFmJzRo8CzaWi3t92xfvQuzfauD8B9mbK9Wgo1MF0XM+2irXZIawJp8CNdMTDh/ERKkXU/XbHrdQMGUK/9EwVEQr3wTAcUFBm7u47UZps= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1782212119; c=relaxed/simple; bh=dMs84Lx4JEfl3gK0UjGs//HPuGE8aydmHqcvb1O1sfY=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LAq/fPABdny3TsXBFnLHx6XNVWBO2Qs66V2VOEAD+0Q6zWgcRrpDeZucojReSme3SbZmX8wiWGN80kOeeSfN3OtXtEralmAQRzknWr+QTYSvf8kBcLHxLNUGYO8ZL/uFwAU69V45nha1dVdPC5JAaA9XXN1EcQERqevfyrGZKlA= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WDVux+5r DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 984274BA23C4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1782212119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LOFknAjxrS0UZKE2EYbkKa657jKowEhkwDTG26B/LIM=; b=WDVux+5rcw/zLOdQaAG3zzTR/4kglES/2UDOYZLqGtfmcC3AJMAMHSu76obk9f4IAQMdY0 LDzEEx/t9GpvcRtfaeGG7+hwxV7XNpgkl2u/2nHQYkyfIiCqLQuL+ggIcq4LMnu8BJRhcR eNNd5jsl0mfKDdOmgVcoIU8sEH0AFHY= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-88-2HlXbVKBOCeYcguMuCJOTw-1; Tue, 23 Jun 2026 06:55:18 -0400 X-MC-Unique: 2HlXbVKBOCeYcguMuCJOTw-1 X-Mimecast-MFC-AGG-ID: 2HlXbVKBOCeYcguMuCJOTw_1782212117 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-490a767c7dcso36683805e9.2 for ; Tue, 23 Jun 2026 03:55:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782212117; x=1782816917; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=LOFknAjxrS0UZKE2EYbkKa657jKowEhkwDTG26B/LIM=; b=Poa8AcFX2hRd/zmdhMzUsoLY5bL4WvOCcejo/UPCZVdfCnYRklTNjj6q2GUp/9cqmN 5d1+3Jd+Nug8fIXRcid8pJ2RdMF45tdwxVAn0t5u5mI5GRqZ5BXcCyk0HLD5rP1LIqya 08ah1WE+0TColvTA1SOwFTjZgGl5/R4nczxEsZGvN/nFpYr8RpmcnjsP32MiGANZOivN ci5EgiwVmk/gDaHBy/hiKHsCvcDKvJtPx6ZJvPiRMA6a+Zoxy//n6HxMFN/856mdGULm qlNbLSUyXMorwC5rd3jW+YjBx4uJygQ6qHYfda2xl1wzBg6AZULF+RdqJZ7+88sQNoQr bGcw== X-Forwarded-Encrypted: i=1; AFNElJ8K8paVRIhMcahAjv+fNKC0xzB5mC5MnwfRB1XJHXzsVgrlV/E+oJoq37JTJo/OBiJnqVvfxtswIUyJWw==@sourceware.org X-Gm-Message-State: AOJu0YzQlZQ+yakpQBLxDJhLXAeWnbxUUuBfIrH6JbAxs8iMeZVQTJys +GgMvmy/PS4l97XUi9py+wtINorp18nzfp/0udWpBlv1BdOfVZAMUuqaDPrENbLpLvhhjuzMvgi FYNjzEKk7y3h/hxlEjEn5TbskYWxhPkhV2eN+yNvAoFn34RzCERSps4cs5ZODdaQPU666E0o= X-Gm-Gg: AfdE7cnRVsNLCFj8II7XLWUhY0IegKSiM2u9Eo+p4Lsx3kJLgYchK/9f7R2FxOVtBjJ m/pjz+EbqR0mVWie8wPiHRLbmPNvr/L9+6Uvjat2Vo71fwujYB59//e0dVQCrmJPS/XXaCRCiOP FvAu/lS/D4neTjBPQxWgKbvEucT1x83ofSLdSsm9HVboHurkep8Io5n6IG9mM91T6vZTJc0gw2n 4s7dmoiHLWXSkasGk7LCYnLZ+ZfYiBGbbkx4nVuUcHxvKdq1MbWbf3GdFeBEqWiczOz14Kfdg4t 8OhQJd2dNdNKs0B+VxgHcg43pc4RDBaI5hiaDINDyTc9XQrYdfL3B4cZuNfR9fSBNXlY/aRF16r NCf726sHctJETvMBCBCrrn4Q3DdsmLg== X-Received: by 2002:a05:600c:4747:b0:492:1e36:85dc with SMTP id 5b1f17b1804b1-4925b3bea23mr35994155e9.36.1782212116914; Tue, 23 Jun 2026 03:55:16 -0700 (PDT) X-Received: by 2002:a05:600c:4747:b0:492:1e36:85dc with SMTP id 5b1f17b1804b1-4925b3bea23mr35993645e9.36.1782212116468; Tue, 23 Jun 2026 03:55:16 -0700 (PDT) Received: from localhost (19.81.93.209.dyn.plus.net. [209.93.81.19]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49245a69f81sm345135395e9.1.2026.06.23.03.55.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 Jun 2026 03:55:16 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCHv2 2/2] gdb: convert sentinel_frame to a frame_info_ptr In-Reply-To: <5da0dcef-b250-4c06-b97c-e288e1c28e11@simark.ca> References: <75107040e4b5cdaa04f7e954d36d36857cbc8318.1782163808.git.aburgess@redhat.com> <5da0dcef-b250-4c06-b97c-e288e1c28e11@simark.ca> Date: Tue, 23 Jun 2026 11:55:15 +0100 Message-ID: <87qzlxo7ak.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2QH_86FOOrjayCvTRbt0ArFZqpFVFihIqLpc_z6_OKw_1782212117 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Simon Marchi writes: > On 6/22/26 5:33 PM, Andrew Burgess wrote: >> @@ -1726,12 +1763,12 @@ get_current_frame (void) >> if (get_traceframe_number () < 0) >> validate_registers_access (); >> >> - if (sentinel_frame == NULL) >> - sentinel_frame = >> - create_sentinel_frame (current_program_space, >> - current_inferior ()->aspace.get (), >> - get_thread_regcache (inferior_thread ()), >> - 0, 0).get (); >> + if (sentinel_frame == nullptr) > > While this works, in the previous patch you have used ".is_null ()". > I'm pointing it out in case you want to change it, but otherwise it > doesn't bother me too much. I actually realised about an hour after posting these patches that my choice to use is_null was weird. We mostly compare frame_info_ptr objects to nullptr throughout GDB, treating them as if they actually were pointers. I plan to update the previous patch to use comparison to nullptr before pushing as I think that is far more common throughout GDB. Thanks, Andrew > > Otherwise LGTM. > > Approved-By: Simon Marchi > > Simon