From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pDzaDvzEX2q4eiEAWB0awg (envelope-from ) for ; Tue, 21 Jul 2026 15:14:04 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IubItcZa; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 22F9C1E09E; Tue, 21 Jul 2026 15:14:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6454E1E033 for ; Tue, 21 Jul 2026 15:14:03 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DB1834BA2E13 for ; Tue, 21 Jul 2026 19:14:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB1834BA2E13 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IubItcZa Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id C4FFB4BA2E27 for ; Tue, 21 Jul 2026 19:13:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C4FFB4BA2E27 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C4FFB4BA2E27 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784661218; cv=none; b=CahuCF9ocLcivRvPgg947f/6WzXDdzhIj7Ob8JJhYdCFbskyXAQMiIr6ddL6gYAfcU6zPLAgz2dfpSJEYXt3wCq4ForIKErkchcNEVq5/MUd7vQ6E/CtM4QkJ3L2j/z3bFfp72bg4KwcTsAb9Z30EeHb3JNQEcTVxTAWKTUbHbk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784661218; c=relaxed/simple; bh=ZKEpkWg9Z48ppjv3KyfK8JJHksV3sjfxZSFhv8xcLjk=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=qtGljNcTA/RwJTRQ8Stgjf14OrweG8bixNwSLhwt89YbCVZrpltQDtCJ0YzyKewBQbGTekjPURYm8fHTn9hF3nOlHo7X37IAvIk1Qoz08O6RusWIuhjMYNuqyCr197TACR8Yq8S65e96Pb51DlWYOm7Eveci8LZvTgFFmPUOC/Q= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=IubItcZa reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C4FFB4BA2E27 Received: from eig-obgw-5004b.ext.cloudfilter.net ([10.0.29.208]) by cmsmtp with ESMTPS id m6KawwszfaC0UmFuKws2KI; Tue, 21 Jul 2026 19:13:36 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id mFuJwbBgbLQlXmFuKw9zES; Tue, 21 Jul 2026 19:13:36 +0000 X-Authority-Analysis: v=2.4 cv=AeWxH2XG c=1 sm=1 tr=0 ts=6a5fc4e0 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=RAioF0-LDSMA:10 a=ItBw4LHWJt0A:10 a=zd2uoN0lAAAA:8 a=PeVKdbYfcNjLkwrjmRQA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EcuGT+M55JfXsllX34AinsTJptaKTX3LAV64jESCWoQ=; b=IubItcZalwEEvZ4OPORIwaYMkV XDmDnUYAVGlPKwE5MxQhti0vAUkkg3fpAp20Vxb2FR6/1/YJSHc1cZM6fwRdgllEr+1IDqxuIAKIt efk/XO0D/TiDwMA6ZQmheTIvP; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:53640 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.2) (envelope-from ) id 1wmFuJ-00000004Cg5-2PfJ; Tue, 21 Jul 2026 13:13:35 -0600 From: Tom Tromey To: Tankut Baris Aktemur Cc: Subject: Re: [PATCH 07/16] gdb: convert type instance flags to bitfields In-Reply-To: <20260713-users-aktemur-type-instance-flags-v1-7-779cad0c85ec@amd.com> (Tankut Baris Aktemur's message of "Mon, 13 Jul 2026 09:00:06 -0500") References: <20260713-users-aktemur-type-instance-flags-v1-0-779cad0c85ec@amd.com> <20260713-users-aktemur-type-instance-flags-v1-7-779cad0c85ec@amd.com> X-Attribution: Tom Date: Tue, 21 Jul 2026 13:13:34 -0600 Message-ID: <87qzkwrw9t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wmFuJ-00000004Cg5-2PfJ X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:53640 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfPjvw8n3WOXn19WhUZMJE4vHZT4yTwUab1sRbZgLcZOCke/9euuelYz0ub0TN+N5CG0n0hU6h1ZXrTwgWpjFn5PzGy/01Fm4K+4vNXWThCjGn8S2o+uA 0gx70WG/UWyUHOEEK2QNc5/tMSstulAHpV3TbtXLzOkY3hxhc9AGdgscal4oV6HduYprnYWXvQzumUJzNy3GQHgSZWVUtO/UE7E= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> Tankut Baris Aktemur writes: > Convert the instance flags of a type to a struct with bitfields. This > helps avoid bitwise operations and instead refer to the fields by > name. In particular, Harvard address space information (i.e. code > space and data space) and address class information become enum values > instead of being handled by seemingly independent bits. Thanks. I like this direction. I have a couple minor questions. > + type_instance_flags &operator|= (const type_instance_flags &other) > + { ... > + harvard_aspace > + = static_cast (harvard_aspace > + | other.harvard_aspace); > + address_class = address_class | other.address_class; These two assignments in particular don't really make sense to me. Perhaps they should assert that the relevant member of 'this' is 0? > @@ -1593,7 +1616,7 @@ struct type > instance flags are completely inherited from the target type. No > qualifiers can be cleared by the typedef. See also > check_typedef. */ > - unsigned m_instance_flags : 9; > + type_instance_flags m_instance_flags; I would guess this increases the size of 'struct type'. I don't think it's a big deal, but I'm curious about it. Tom