From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sz81MC3NfGrDIiEAWB0awg (envelope-from ) for ; Wed, 12 Aug 2026 15:44:45 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=nzzBg4VT; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B48471E09B; Wed, 12 Aug 2026 15:44:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AF7C51E09B for ; Wed, 12 Aug 2026 15:44:44 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C5F114BB3BA5 for ; Wed, 12 Aug 2026 19:44:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C5F114BB3BA5 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=nzzBg4VT Received: from omta038.useast.a.cloudfilter.net (omta038.useast.a.cloudfilter.net [44.202.169.37]) by sourceware.org (Postfix) with ESMTPS id B7FD84BB3B8D for ; Wed, 12 Aug 2026 19:44:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B7FD84BB3B8D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B7FD84BB3B8D Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.37 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786563853; cv=none; b=ivY8xs51xJ1JR+zlbVIBBy2pmnJbjrUjChqPsmC5fITxc3r6gv3YIXXJqjCg8deOE6+d4f8YF52dpe4JT9VqH4OB/QZYcpOFljwCvjENVcVCKUAxrwJa6RmZR5HLR3z/txACc7ZEumvceJRiizwv9/4HF/3RQ4om43MtSV7mh20= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1786563853; c=relaxed/simple; bh=SDwZCG7hKrRXTS8v4dA7QyNxspMUfvGr+lDuWk2T2Po=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=E21oZo9CVGLHEX9wzajKppeI6Y+WmHgrFnU2sMrqMilWPVuwhRhpUCsbDJlg3ESypN1+mP15qZbSNkWz1HtPAlSzGMtiMbNL94AhyoIRJz9vFyrA/t5+NHaHH5PyFBu3HY5hZnHkaejshKxLLQl5LEQKxUbvp+mI1RzWfG1/DY8= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=nzzBg4VT reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7FD84BB3B8D Received: from eig-obgw-5006b.ext.cloudfilter.net ([10.0.29.217]) by cmsmtp with ESMTPS id uEBIw81xDJFmFuEs1wOVVW; Wed, 12 Aug 2026 19:44:13 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id uEs0wxJGGWDCxuEs0wgnVz; Wed, 12 Aug 2026 19:44:13 +0000 X-Authority-Analysis: v=2.4 cv=Qpte3Uyd c=1 sm=1 tr=0 ts=6a7ccd0d a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=lH-9HXx2uMJfkVAtUdgA:9 a=4G6NA9xxw8l3yy4pmD5M:22 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cW0BNw43ZSQwNw7SydYALvbkabHJV6//GrdoFZVfh3M=; b=nzzBg4VTyhJu9VaqnZy16TM7ek SLLbk/7ANKgKaegYo9XTLYl3Vf4mVySFEkyXlPfrm0Vl0yS9aE/8ryOpyP7FgeuDKXNluyQSlnwig Wkk4yMH0mFxmdW8Fl2Ny6OXIn; Received: from 75-166-225-82.hlrn.qwest.net ([75.166.225.82]:40406 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wuEs0-000000037rV-1734; Wed, 12 Aug 2026 13:44:12 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv2] gdb/tui: use init_extended_color where possible In-Reply-To: <5da7a3fea6997922a87508807efc3cadd119ff7c.1785930494.git.aburgess@redhat.com> (Andrew Burgess's message of "Wed, 5 Aug 2026 12:50:53 +0100") References: <5da7a3fea6997922a87508807efc3cadd119ff7c.1785930494.git.aburgess@redhat.com> X-Attribution: Tom Date: Wed, 12 Aug 2026 13:44:11 -0600 Message-ID: <87qzk3w2d0.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.225.82 X-Source-L: No X-Exim-ID: 1wuEs0-000000037rV-1734 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-225-82.hlrn.qwest.net (bapiya) [75.166.225.82]:40406 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfEqWpKQG8+kskRbB+njwwr4E0OXFaCJkVyN+J7TIKGaBAM7eOetuKxBHyonsdmWKY9nfwIcHgolxlDeHqQDU/UOKMZJqP3TlT61XLjqCbXqx6guAZ2Pc f9y0ELg1NZNHXU4zhFYYb1f+hdg+QJ7kPzwn0JO1RJliBuMG0XPYkHDb8mMvH7D8q6OyAgdX28aBbnay7jATAytbD9hN5WRMQkI= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Andrew" == Andrew Burgess writes: Andrew> The motivation for using init_extended_color is slightly less than Andrew> init_extended_pair. Assuming the terminal supports it the standard Andrew> init_color API supports up to SHRT_MAX (32767) different colors, Andrew> switching to init_extended_color removes the SHRT_MAX limit on color Andrew> indices, allowing us to support the full range of COLORS. First, I think the patch is fine. Approved-By: Tom Tromey However I have a question Andrew> /* We store RGB as 0..255, but curses wants 0..1000. */ Andrew> - if (init_color (next, rgb[0] * 1000 / 255, rgb[1] * 1000 / 255, Andrew> - rgb[2] * 1000 / 255) == ERR) Andrew> + short r = rgb[0] * 1000 / 255; Andrew> + short g = rgb[1] * 1000 / 255; Andrew> + short b = rgb[2] * 1000 / 255; Andrew> + Andrew> + /* If init_extended_pair is not available then we fallback to Andrew> + using init_pair. However, init_pair can only handle 'short' Andrew> + color indices so there is no point using init_extended_color Andrew> + to allow for the generation of longer 'int' color indices. */ Andrew> +#if defined HAVE_INIT_EXTENDED_COLOR && defined HAVE_INIT_EXTENDED_PAIR Andrew> + if (init_extended_color (next, r, g, b) == ERR) Andrew> return false; Andrew> +#else Andrew> + /* NEXT is an int, but is passed as a short. If COLORS is Andrew> + more than SHRT_MAX then NEXT will be truncated and end up Andrew> + redefining a color entry that we don't expect. */ Andrew> + if (next > SHRT_MAX Andrew> + || init_color (next, r, g, b) == ERR) Andrew> + return false; Andrew> +#endif IIUC init_extended_color allows a bigger range for 'next' but also for the RGB components. However despite the text above, I think we don't actually use the bigger RGB range. And, perhaps we don't really care to, I don't know. Tom