From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QfAOJRFbkGqC0AYAWB0awg (envelope-from ) for ; Thu, 27 Aug 2026 11:43:13 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jU8X9h7v; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 935C91E166; Thu, 27 Aug 2026 11:43:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F10CD1E033 for ; Thu, 27 Aug 2026 11:43:12 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BC6F64BA2E16 for ; Thu, 27 Aug 2026 15:43:11 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BC6F64BA2E16 Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jU8X9h7v Received: from omta036.useast.a.cloudfilter.net (omta036.useast.a.cloudfilter.net [44.202.169.35]) by sourceware.org (Postfix) with ESMTPS id 41F774BA2E05 for ; Thu, 27 Aug 2026 15:42:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41F774BA2E05 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 41F774BA2E05 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=44.202.169.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787845366; cv=none; b=iaVxBGl2JMNyArF5OpnJw38xxYjY8EwhPHXzQMO6h6QLDtXoa0oZo+bi/NQkfeEbg+cQukuNP24b5JWAKTCjqtrO77CPk3xxPyshWGDHBHbarkGv2lkFM8FgxVBWKxAmr4hqBJ5R/05GvfqJyRojLCE3ggefLDzftMpanjdu+og= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787845366; c=relaxed/simple; bh=XEFmJmqmkmqZgcXBRadAxoomc+RAxTx9BeEduRArdaI=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=ut5BXygVriDIKxIwzsef4jHTjQEfmK68vECm1IICLYv4DYSgCxOGrb8KTZu4S3kuD6xL3KaX2oxwWjejcF8dEYyftrpyZlsDqJAd9SA18/Hsg5oMKFQ6oKcJmFiwX1mibJQdTpFsFtCT+PIlMD+sYnhpG1v0erWXaXRYFW4APuw= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=jU8X9h7v reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41F774BA2E05 Received: from eig-obgw-5002b.ext.cloudfilter.net ([10.0.29.226]) by cmsmtp with ESMTPS id zX0Lw88GSLvgbzcFZwxWAZ; Thu, 27 Aug 2026 15:42:45 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id zcFXwDYYwadLAzcFXw3zzi; Thu, 27 Aug 2026 15:42:43 +0000 X-Authority-Analysis: v=2.4 cv=Aqzu3P9P c=1 sm=1 tr=0 ts=6a905af4 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=Sv0fKeRqtYgA:10 a=ItBw4LHWJt0A:10 a=3mwE1B7c-v9z0bvJQwoA:9 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ABdOpogU8H8V5oiwq96orQt2CX071KwYonCrZuAIZ58=; b=jU8X9h7vWDa0ipwtRBLGaT9L+H W8GOaTg8/LNCDIgqbrRHFMQBS6RRFiVIIhGwRyPt+2VChYHRad4dsL6W6e63/ofoTcREV5qKWSXnr w6vX/ezNtG/LZABy29V6AKGaI; Received: from 97-122-117-2.hlrn.qwest.net ([97.122.117.2]:51082 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.99.5) (envelope-from ) id 1wzcFX-00000003Csb-08Pu; Thu, 27 Aug 2026 09:42:43 -0600 From: Tom Tromey To: Rainer Orth Cc: Andrew Burgess , Tom Tromey , gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] Skip gdb.dap/pause.exp on Solaris [PR34548] In-Reply-To: (Rainer Orth's message of "Tue, 25 Aug 2026 10:19:33 +0200") References: <87fr07tupw.fsf@tromey.com> <874igj26tf.fsf@redhat.com> X-Attribution: Tom Date: Thu, 27 Aug 2026 09:42:41 -0600 Message-ID: <87qzjja7ta.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.117.2 X-Source-L: No X-Exim-ID: 1wzcFX-00000003Csb-08Pu X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-117-2.hlrn.qwest.net (bapiya) [97.122.117.2]:51082 X-Source-Auth: tom+tromey.com X-Email-Count: 10 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfMvzeTWdRqcLqwxhikqoQnwXhoAwulLIoKh+jwPVmTF9wS/7mNgwQXv/LSTLtkRukCEq1uzFKU3PhlUUCiWHEZyn6wHV7R/vnqs+Z3SbDa52iqNjWYOf kWO+bCLZ+SdfwHALBmPsDX1VARet6uuoL6S4lpp1Bawk3mwQLEtDEg3NFbOl6qIv27uZLYa9nq06xj8HD2us81H4i1at8KLDqwk= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org >>>>> "Rainer" == Rainer Orth writes: Rainer> Right: some of them already do their own checks for async support: Rainer> gdb.base/async.exp Rainer> gdb.base/bg-exec-sigint-bp-cond.exp Rainer> gdb.base/interrupt-noterm.exp Rainer> but in those cases, async commands are a crucial part of the tests and I Rainer> couldn't easily use the new supports_target_async there. I think it would be fine to stick require supports_target_async At the top of each of these files, and simplify some of the tests to just assumes async execution will work. However that can also be comfortably done in a separate patch as well. Rainer> +# Return 1 if target supports asynchronous execution, otherwise return 0. Rainer> +gdb_caching_proc supports_target_async {} { Rainer> + global srcdir subdir gdb_prompt Rainer> + Rainer> + set me "supports_target_async" Rainer> + Rainer> + set src { int main() { return 0; } } Rainer> + if {![gdb_simple_compile $me $src executable ""]} { Rainer> + return 0 Rainer> + } Rainer> + Rainer> + gdb_exit Rainer> + gdb_start Rainer> + gdb_reinitialize_dir $srcdir/$subdir I think these three lines can be replaced with "clean_restart". Rainer> + if { ![runto_main] } { Rainer> + return 0 This branch doesn't gdb_exit but falling through does. Likewise this return doesn't delete the file. So maybe reworking this to fall through to the cleanup & final return would be better. thanks, Tom