From: Tom Tromey <tromey@adacore.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sourceware.org, Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH] Add QUIT to inner loop in value_print_array_elements
Date: Wed, 30 Sep 2026 11:54:07 -0600 [thread overview]
Message-ID: <87qziahbgg.fsf@tromey.com> (raw)
In-Reply-To: <20260925172315.20eb519c@f44-mesa-1> (Kevin Buettner's message of "Fri, 25 Sep 2026 17:26:57 -0700")
>>>>> "Kevin" == Kevin Buettner <kevinb@redhat.com> writes:
Kevin> My AI-enabled patch review workflow confirmed Gwen's finding.
Kevin> It said:
Kevin> Finding 1 -- the dominant uninterruptible loop is in char-print.c,
Kevin> not the array code.
Kevin> value_print_array_elements never appears.
I think this is testing for and has discovered a separate bug.
My patch affects array printing, not string printing. So a test that
examines strings should not be expected to have different behavior.
Anyway I'll add a QUIT in char-print.c.
Tom
next prev parent reply other threads:[~2026-09-30 17:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 20:12 Tom Tromey
2026-09-24 20:36 ` Guinevere Larsen
2026-09-26 0:26 ` Kevin Buettner
2026-09-30 17:54 ` Tom Tromey [this message]
2026-09-30 18:02 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87qziahbgg.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox