From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26051 invoked by alias); 17 Feb 2012 20:24:28 -0000 Received: (qmail 26039 invoked by uid 22791); 17 Feb 2012 20:24:27 -0000 X-SWARE-Spam-Status: No, hits=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 17 Feb 2012 20:24:10 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1HKOAWd008641 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Feb 2012 15:24:10 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q1HKO907008388; Fri, 17 Feb 2012 15:24:09 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id q1HKO8ls012066; Fri, 17 Feb 2012 15:24:08 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org, jan.kratochvil@redhat.com Subject: Re: [PATCH 1/2] gdb.threads/attach-into-signal.exp: cleanup References: <20120217193546.10029.74207.stgit@hit-nxdomain.opendns.com> <20120217193648.10029.26589.stgit@hit-nxdomain.opendns.com> Date: Fri, 17 Feb 2012 20:55:00 -0000 In-Reply-To: <20120217193648.10029.26589.stgit@hit-nxdomain.opendns.com> (Pedro Alves's message of "Fri, 17 Feb 2012 19:36:48 +0000") Message-ID: <87pqdd9pjs.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00378.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> - build different executable files for the non-threaded and threaded Pedro> cases. This was my motivation. I wanted to test the non-threaded Pedro> case manually, but the threaded variant always clobbered the Pedro> non-threaded executable. I think this ought to be a general rule. We need exceptions to it for some executable-changed cases, but I think in general different tests should build different executables, because this makes it easier to do additional checking by hand. Pedro> + set save_pf_prefix $pf_prefix Pedro> + lappend pf_prefix "$threadtype:" I think this should be append rather than lappend, as pf_prefix is just a string, not a list. Pedro> if [get_compiler_info ${binfile}] { Pedro> + set pf_prefix $save_pf_prefix Pedro> return -1 Pedro> } I've occasionally wanted a wrapper like 'with_pf_prefix $whatever { body }'. But not enough to write it :) Tom