From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-88737-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 9085 invoked by alias); 9 Mar 2012 21:03:57 -0000
Received: (qmail 9074 invoked by uid 22791); 9 Mar 2012 21:03:56 -0000
X-SWARE-Spam-Status: No, hits=-6.9 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 09 Mar 2012 21:03:43 +0000
Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q29L3gns024514	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Fri, 9 Mar 2012 16:03:42 -0500
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q29L3f2m005051	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Fri, 9 Mar 2012 16:03:42 -0500
From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/3] Refactor internal variable mechanism
References: <m3boo5cyd8.fsf@redhat.com> <m3ty1xbjnh.fsf@redhat.com>
Date: Fri, 09 Mar 2012 21:03:00 -0000
In-Reply-To: <m3ty1xbjnh.fsf@redhat.com> (Sergio Durigan Junior's message of	"Fri, 09 Mar 2012 17:32:02 -0300")
Message-ID: <87pqclij0y.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-03/txt/msg00359.txt.bz2

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> This is the first patch, which refactors the internal variable
Sergio> mechanism.  It creates new methods, for example to compile an internal
Sergio> variable into agent expression.

Sergio> Is this OK to check-in?

I intend to approve this one but I would like to wait for other comments
first.

Really I'm replying now to point out a nit :)

Sergio> +/* Implementation of `thread' variable.  */
Sergio> +
Sergio> +static struct internalvar_funcs thread_funcs =

This one should be 'const' like the others are.

Tom