Re: [RFC] init_breakpoint_sal: Add quotes around part of command in error message

Stan Shebs
2012-05-15T16:49:43Z

On 5/15/12 7:59 AM, Joel Brobecker wrote:
> gdb/ChangeLog:
>
> * breakpoint.c (init_breakpoint_sal): Add quotes around part
> of command in two error message.
>
> Untested for now, just trying to get feedback. Will definitely test
> before checking in, if people like the change.
>

I think the quoting is a good general principle to follow whenever
reporting any string that originates from user input, or from the
target; cut-n-paste errors and twitchy mice can conspire to generate
thoroughly confusing errors if the strings are not delimited somehow. I
could go with either double quotes or single quotes, but as Jan points
out, the general style seems to prefer a pair of single quotes.

Stan