From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-91762-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12282 invoked by alias); 4 Jun 2012 20:27:57 -0000
Received: (qmail 12273 invoked by uid 22791); 4 Jun 2012 20:27:56 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 04 Jun 2012 20:27:44 +0000
Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q54KRi65025766	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 4 Jun 2012 16:27:44 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q54KRhYA004480	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 4 Jun 2012 16:27:43 -0400
From: Tom Tromey <tromey@redhat.com>
To: Sergio Durigan Junior <sergiodj@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 06/10] Java language
References: <1338665528-5932-1-git-send-email-sergiodj@redhat.com>	<1338665528-5932-7-git-send-email-sergiodj@redhat.com>
Date: Mon, 04 Jun 2012 20:27:00 -0000
In-Reply-To: <1338665528-5932-7-git-send-email-sergiodj@redhat.com> (Sergio	Durigan Junior's message of "Sat, 2 Jun 2012 16:32:04 -0300")
Message-ID: <87pq9en7pd.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.97 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-06/txt/msg00095.txt.bz2

>>>>> "Sergio" == Sergio Durigan Junior <sergiodj@redhat.com> writes:

Sergio> -static void insert_exp (int, struct expression *);
Sergio> +static void insert_exp (struct parser_state *, int, struct expression *);

If you ever want to do another cleanup in this area, here's an
opportunity :)

IMNSHO language parsers should not be manipulating the expout data
structure like this.  copy_exp is likewise naughty.

Tom