From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-93014-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 1356 invoked by alias); 23 Jul 2012 19:08:49 -0000
Received: (qmail 1346 invoked by uid 22791); 23 Jul 2012 19:08:48 -0000
X-SWARE-Spam-Status: No, hits=-6.5 required=5.0	tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Jul 2012 19:08:35 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6NJ8ZQb009727	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 23 Jul 2012 15:08:35 -0400
Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6NJ8Ylg006432	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 23 Jul 2012 15:08:35 -0400
From: Tom Tromey <tromey@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 01/10] change gdb to refcount bfd everywhere
References: <87vchk3lxs.fsf@fleche.redhat.com>	<20120719141750.GB23801@host2.jankratochvil.net>	<877gtzxyck.fsf@fleche.redhat.com> <87sjcmv16h.fsf@fleche.redhat.com>	<20120723085355.GA29593@host2.jankratochvil.net>	<877gtuqpfo.fsf@fleche.redhat.com>	<20120723190229.GA15168@host2.jankratochvil.net>
Date: Mon, 23 Jul 2012 19:08:00 -0000
In-Reply-To: <20120723190229.GA15168@host2.jankratochvil.net> (Jan	Kratochvil's message of "Mon, 23 Jul 2012 21:02:29 +0200")
Message-ID: <87pq7mpa6l.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2012-07/txt/msg00470.txt.bz2

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> On Mon, 23 Jul 2012 20:53:47 +0200, Tom Tromey wrote:
>> else if (bfd_check_format (abfd, bfd_archive))
>> {
>> -      last = 0;
>> -      /* FIXME??? am I tossing BFDs?  bfd?  */
>> -      while ((last = gdb_bfd_openr_next_archived_file (abfd, last)))
>> +      last = gdb_bfd_openr_next_archived_file (abfd, NULL);
>> +      while (last != NULL)

Jan> So you have resolved this question I see.

Not really to my satisfaction.
I just brought it in line with machoread.c, which is more actively
maintained.

I'll try to dig up a definitive answer.

Tom