From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10926 invoked by alias); 24 Jul 2012 20:47:23 -0000 Received: (qmail 10916 invoked by uid 22791); 24 Jul 2012 20:47:22 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 24 Jul 2012 20:47:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6OKl6Wg022406 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 24 Jul 2012 16:47:06 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6OKl4At019587 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Tue, 24 Jul 2012 16:47:05 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH 3/6] attach to command_option-changed observer. References: <1343146252-22558-1-git-send-email-yao@codesourcery.com> <1343146252-22558-4-git-send-email-yao@codesourcery.com> Date: Tue, 24 Jul 2012 20:47:00 -0000 In-Reply-To: <1343146252-22558-4-git-send-email-yao@codesourcery.com> (Yao Qi's message of "Wed, 25 Jul 2012 00:10:49 +0800") Message-ID: <87pq7knayf.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00506.txt.bz2 >>>>> "Yao" == Yao Qi writes: Yao> 2012-07-24 Yao Qi Yao> * NEWS: Mention new MI notification. Yao> * mi/mi-interp.c: Declare mi_command_option_changed. Yao> (mi_interpreter_init): Attach mi_command_option_changed to Yao> observer command_option_changed. Yao> (mi_command_option_changed): New. Yao> * mi/mi-main.c (mi_cmd_execute): Check command 'gdb-set' and set Yao> mi_suppress_notification. Yao> * mi/mi-main.h: New enum 'MI_SUPPRESS_COMMAND'. Yao> +static void Yao> +mi_command_option_changed (const char *option, const char *value) Needs an intro comment; something small is fine. Yao> + fprintf_unfiltered (mi->event_channel, Yao> + "option-changed,option=\"%s\",value=\"%s\"", Yao> + option, value); This has a quoting bug. VALUE can contain characters requiring special quoting for MI. I once wrote a patch to change the event channel to use ui-out: http://sourceware.org/ml/gdb-patches/2011-01/msg00518.html That would be one way to deal with the problem, but there are probably other ways as well. (I didn't commit that patch because Volodya had a different approach to emitting the notifications that I was interested in... but I still think it is a decent idea.) Yao> + else if (strncmp (parse->command, "gdb-set", sizeof ("gdb-set") - 1 ) == 0) There's an extra space before the closing paren. I don't like this approach much but I understand why you did it. Yao> +enum MI_SUPRESS_NOTIFICATION { MI_SUPPRESS_BREAKPOINT, MI_SUPPRESS_COMMAND }; Put each constant on its own line. Tom