From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25010 invoked by alias); 26 Jul 2012 13:52:57 -0000 Received: (qmail 25001 invoked by uid 22791); 26 Jul 2012 13:52:56 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 26 Jul 2012 13:52:40 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q6QDqdaW001881 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 26 Jul 2012 09:52:39 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id q6QDqbcF016711 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 26 Jul 2012 09:52:38 -0400 From: Tom Tromey To: Keith Seitz Cc: gdb-patches ml , Hui Zhu Subject: Re: [PATCH Bug breakpoints/14381] Fix linespec to parse file name that begin with decimal numbers References: <500C0A1F.8040106@redhat.com> <87k3xusgan.fsf@fleche.redhat.com> <87lii9ne95.fsf@fleche.redhat.com> <50106327.5000004@redhat.com> Date: Thu, 26 Jul 2012 13:52:00 -0000 In-Reply-To: <50106327.5000004@redhat.com> (Keith Seitz's message of "Wed, 25 Jul 2012 14:20:39 -0700") Message-ID: <87pq7ifx3u.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-07/txt/msg00613.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> Ok for HEAD and 7.5? One nit... Keith> + && !isspace(*PARSER_STREAM (parser)) && *PARSER_STREAM (parser) != ',' Space after "isspace". Ok with that fix, thanks. Tom