From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3671 invoked by alias); 7 Dec 2012 14:43:43 -0000 Received: (qmail 3662 invoked by uid 22791); 7 Dec 2012 14:43:42 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 07 Dec 2012 14:43:36 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qB7Eha8R007735 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 7 Dec 2012 09:43:36 -0500 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qB7EhYJj007507 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 7 Dec 2012 09:43:35 -0500 From: Tom Tromey To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: RFC: automatic dependency tracking for gdbserver References: <87r4n6vnqx.fsf@fleche.redhat.com> <50C1C285.5070904@redhat.com> Date: Fri, 07 Dec 2012 14:43:00 -0000 In-Reply-To: <50C1C285.5070904@redhat.com> (Pedro Alves's message of "Fri, 07 Dec 2012 10:18:45 +0000") Message-ID: <87pq2lx6qx.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2012-12/txt/msg00171.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> I think I'd mildly prefer having these listed explicitly in Pedro> acinclude.m4, so you can do just autoreconf on the command line Pedro> or aclocal, without worrying about forgetting -I (IIRC, Pedro> ACLOCAL_AMFLAGS is actually ignored, because we're not using Pedro> automake). WDYT? Sure, I will make that change. Pedro> I actually have a patch for GDB that does the Pedro> same to gdb's aclocal. I think the change would be fine, but gdb does actually use this variable: $(srcdir)/aclocal.m4: @MAINTAINER_MODE_TRUE@ $(aclocal_m4_deps) cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS) gdbserver doesn't seem to have these maintainer-mode rebuild rules. All these little details are a benefit of automake; but I looked at that a bit and it is kind of a pain to switch over. Pedro> I do wonder why does acinclude.m4 use sinclude instead of Pedro> include. I don't see why you'd ever want those includes to Pedro> silently fail. Yeah, that is weird. Tom