From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19365 invoked by alias); 12 Apr 2013 16:32:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19354 invoked by uid 89); 12 Apr 2013 16:32:15 -0000 X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 12 Apr 2013 16:32:15 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3CGW7x6018953 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 12 Apr 2013 12:32:08 -0400 Received: from barimba (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r3CGW5uo016418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 12 Apr 2013 12:32:06 -0400 From: Tom Tromey To: Hui Zhu Cc: Pedro Alves , Eli Zaretskii , Hui Zhu , gdb-patches ml , Marc Khouzam Subject: Re: [PATCH] add -s option to make -break-insert support dprintf References: <515451EA.1000200@mentor.com> <83y5d7wpvq.fsf@gnu.org> <516454DA.9040109@redhat.com> Date: Sat, 13 Apr 2013 14:16:00 -0000 In-Reply-To: (Hui Zhu's message of "Thu, 11 Apr 2013 10:40:58 +0800") Message-ID: <87ppxzhfqy.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-04/txt/msg00398.txt.bz2 >>>>> "Hui" == Hui Zhu writes: Hui> + [ -s "@var{template},@var{expression}[,@var{expression}@dots{}]" ] Hui> + [ @var{location} ] Hui> +@item -s "@var{template},@var{expression}[,@var{expression}@dots{}]" Hui> +Set a dynamic printf breakpoint, described in @ref{Dynamic Printf}. Hui> +The @var{template} and @var{expression} should be within double Hui> +quotes and be escaped by being preceded with a backslash. MI already defines a quoting approach and allows multiple arguments. In fact one of its selling points is that it doesn't have to be as free-form as the CLI -- it can be more predictable for programs to use. So, I think the above approach is not that great. It adds a second layer of parsing to MI, I guess just to work around internal deficiencies in gdb. It seems like you could use positional arguments instead: -break-insert -s FORMAT LOCATION ARG ARG ARG ... I don't really understand the part about how the expressions should be in double quotes. The test suite doesn't do that: +mi_gdb_test "5-break-insert -s \"\\\"arg=%d, g=%d\\\\n\\\", arg, g\" $dp_location1" \ I suggest just dropping that text. I think it probably means that the argument should be properly quoted for MI, but that is redundant. Tom