From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20077 invoked by alias); 10 May 2013 14:27:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20032 invoked by uid 89); 10 May 2013 14:27:21 -0000 X-Spam-SWARE-Status: No, score=-7.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 10 May 2013 14:27:20 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4AERJEh006262 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 10 May 2013 10:27:19 -0400 Received: from barimba (ovpn-113-133.phx2.redhat.com [10.3.113.133]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r4AERGBW032214 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Fri, 10 May 2013 10:27:18 -0400 From: Tom Tromey To: Phil Muldoon Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/40] add cleanup checker and fix cleanup bugs References: <518C133B.6060401@redhat.com> Date: Fri, 10 May 2013 14:27:00 -0000 In-Reply-To: <518C133B.6060401@redhat.com> (Phil Muldoon's message of "Thu, 09 May 2013 22:20:59 +0100") Message-ID: <87ppwyhpvg.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-05/txt/msg00387.txt.bz2 >>>>> "Phil" == Phil Muldoon writes: Phil> Thanks for doing this, I think it is awesome. I am not going to Phil> comment on the other thirty nine patches as the fixes are largely Phil> mechanical in nature. It wouldn't hurt if someone gave them a second look :) Phil> Will your cleanup checker run as part of the normal build? Phil> (or testsuite)? Phil> (or ARI)? Phil> Or will it be a manual thing? Phil> If it is manual, can it be made automatic? It requires GCC, the GCC Python plugin, and extra arguments to the compiler to tell it to load the checker script. So I think it won't ever be fully automatic. It is pretty easy to run, though. I looked just now at having it run using the installed gcc-with-python2, or using the installed GCC python .so. I think I can make some more improvements to make it even simpler. Though it isn't too hard: yum install gcc-python2-plugin make CC='gcc-with-python2 /full/path/to/check_cleanup.py' Phil> Given the number of errors this tool identified, I think these are Phil> common logic errors? Yes. Phil> What, if any, are the limitations of this, and other, GCC plugins to Phil> fixing common GDB patterns of errors in a common build scenario? The main limitation is the number of false reports it gives. Also see patch #36. Tom