From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4487 invoked by alias); 5 Jul 2013 16:10:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 4453 invoked by uid 89); 5 Jul 2013 16:10:32 -0000 X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KAM_TIME,KHOP_RCVD_UNTRUST,RCVD_IN_DNSWL_MED,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD autolearn=ham version=3.3.1 Received: from e06smtp16.uk.ibm.com (HELO e06smtp16.uk.ibm.com) (195.75.94.112) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Fri, 05 Jul 2013 16:10:13 +0000 Received: from /spool/local by e06smtp16.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 5 Jul 2013 17:04:42 +0100 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp16.uk.ibm.com (192.168.101.146) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 5 Jul 2013 17:04:40 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 6E8EC17D801A for ; Fri, 5 Jul 2013 17:11:40 +0100 (BST) Received: from d06av01.portsmouth.uk.ibm.com (d06av01.portsmouth.uk.ibm.com [9.149.37.212]) by b06cxnps4075.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r65G9vF051904756 for ; Fri, 5 Jul 2013 16:09:57 GMT Received: from d06av01.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r65GA7aY004546 for ; Fri, 5 Jul 2013 10:10:07 -0600 Received: from br87z6lw.de.ibm.com (dyn-9-152-212-143.boeblingen.de.ibm.com [9.152.212.143]) by d06av01.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id r65GA7wm004543; Fri, 5 Jul 2013 10:10:07 -0600 From: Andreas Arnez To: gdb-patches@sourceware.org, Luis Machado Subject: [PATCH] wp-replication: Fix test case loop Date: Fri, 05 Jul 2013 16:10:00 -0000 Message-ID: <87ppuxasyo.fsf@br87z6lw.de.ibm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-TM-AS-MML: No X-Content-Scanned: Fidelis XPS MAILER x-cbid: 13070516-3548-0000-0000-000005DC02F2 X-SW-Source: 2013-07/txt/msg00202.txt.bz2 When executing wp-replication.exp on S/390, the loop that counts the number of available hardware watchpoints does not terminate properly, because *all* "watch" commands yield "hardware watchpoints". Since the C source code is not prepared for more than NR_THREADS hardware watchpoints anyhow, I suggest to add the appropriate exit condition to the loop. 2013-07-05 Andreas Arnez * gdb.threads/wp-replication.exp: Stop counting available hardware watchpoints after NR_THREADS iterations. diff --git a/gdb/testsuite/gdb.threads/wp-replication.exp b/gdb/testsuite/gdb.threads/wp-replication.exp index 8927a43..af3594d 100644 --- a/gdb/testsuite/gdb.threads/wp-replication.exp +++ b/gdb/testsuite/gdb.threads/wp-replication.exp @@ -81,6 +81,10 @@ while { $done == 0 } { gdb_test_multiple "continue" "watchpoint created successfully" { -re ".*Breakpoint 2, empty_cycle \\(\\).*$gdb_prompt $" { incr hwatch_count + if { $hwatch_count == $NR_THREADS } { + set done 1 + break + } } -re ".*Could not insert hardware watchpoint.*$gdb_prompt $" { set done 1