Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom Tromey <tromey@redhat.com>
To: Siva Chandra <sivachandra@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [Patch] PR python/15464 and python/16113
Date: Mon, 13 Jan 2014 21:12:00 -0000	[thread overview]
Message-ID: <87ppnvziuw.fsf@fleche.redhat.com> (raw)
In-Reply-To: <CAGyQ6gzuY0Wd4sXb48L2ZCFsP5MCskWPOwxqLAeQNvvoMdacKQ@mail.gmail.com>	(Siva Chandra's message of "Tue, 7 Jan 2014 06:28:23 -0800")

>>>>> "Siva" == Siva Chandra <sivachandra@google.com> writes:

Tom> I think this approach will fail in the situation where multiple
Tom> anonymous sub-objects appear at the same bitpos.  I think this happens
Tom> with inheritance, typically at bitpos 0 but perhaps elsewhere with
Tom> multiple inheritance.

My example here was totally wrong -- the Field iterator doesn't recurse
into superclasses, so conflicts of the sort I was imagining can't occur.
This seems like a reasonable spot to extend the API someday.

Luckily you found a way to interpret my comment that actually made sense :)

Siva> 2014-12-07  Siva Chandra Reddy  <sivachandra@google.com>

Pessimistic date :)

Siva>         PR python/15464
Siva>         PR python/16133

I think it is PR python/16113, not 16133.

This patch is ok with those two nits fixed.

thanks,
Tom


  reply	other threads:[~2014-01-13 21:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-27 22:38 Siva Chandra
2013-12-30 14:27 ` Siva Chandra
2014-01-06 20:50   ` Tom Tromey
2014-01-07 14:28     ` Siva Chandra
2014-01-13 21:12       ` Tom Tromey [this message]
2014-01-14  1:51         ` Siva Chandra
2014-01-14 14:48         ` Siva Chandra
2014-01-14 14:50           ` Tom Tromey
2014-01-15 12:46             ` Joel Brobecker
2014-01-15 13:19               ` Siva Chandra
2014-01-06 20:36 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ppnvziuw.fsf@fleche.redhat.com \
    --to=tromey@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=sivachandra@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox