From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2175 invoked by alias); 17 Apr 2014 09:04:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2161 invoked by uid 89); 17 Apr 2014 09:04:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_NEUTRAL autolearn=no version=3.3.2 X-HELO: sasl.smtp.pobox.com Received: from a-pb-sasl-quonix.pobox.com (HELO sasl.smtp.pobox.com) (208.72.237.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 17 Apr 2014 09:04:21 +0000 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 9FDF811D55; Thu, 17 Apr 2014 05:04:19 -0400 (EDT) Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 907A311D53; Thu, 17 Apr 2014 05:04:19 -0400 (EDT) Received: from rusty (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 1927711D52; Thu, 17 Apr 2014 05:04:17 -0400 (EDT) From: Andy Wingo To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/9] Allow GDB to build against unreleased Guile 2.2 References: <1397060028-18158-1-git-send-email-wingo@igalia.com> <1397060028-18158-2-git-send-email-wingo@igalia.com> Date: Thu, 17 Apr 2014 09:04:00 -0000 In-Reply-To: (Doug Evans's message of "Sat, 12 Apr 2014 09:40:39 -0700") Message-ID: <87ppkgs4xc.fsf@igalia.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 41D0D4CC-C60F-11E3-A711-873F0E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-SW-Source: 2014-04/txt/msg00340.txt.bz2 Hi, Thanks for the review. I'll post a new patchset shortly incorporating feedback. Sorry for the gaffe with the changelogs. On Sat 12 Apr 2014 18:40, Doug Evans writes: > 2) The change to configure is small, so it's not a big a deal, > but, for reference sake, the convention here is to not include changes > to machine generated files in patches submitted to the list. > Plus I wouldn't expect a change to the Copyright year in configure. I edited the file manually as I don't have autoconf2.64 on my system, hence the copyright year update. I removed the copyright update from the updated patchset, but kept the change to the generated configure file as it's so trivial that I can only imagine autoconf producing exactly those changes. I can repost that patch without that change if you like. > btw, this patch is small enough to not require one, and while I wouldn't > doubt that you have a copyright assignment for Guile changes :-), do you > have one for gdb? I can imagine having a blanket assignment for > everything, just checking. I was agnozing over having to do that when I found to my pleasant surprise that Igalia already has a corporate assignment for GDB, made when Sanjoy Das was doing the custom debug info JIT interface stuff a couple years ago. Hopefully that suffices. Cheers, Andy