From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14071 invoked by alias); 23 Oct 2014 06:24:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14058 invoked by uid 89); 23 Oct 2014 06:24:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Oct 2014 06:24:03 +0000 Received: from svr-orw-fem-05.mgc.mentorg.com ([147.34.97.43]) by relay1.mentorg.com with esmtp id 1XhBoW-0003ts-Da from Yao_Qi@mentor.com ; Wed, 22 Oct 2014 23:24:00 -0700 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-05.mgc.mentorg.com (147.34.97.43) with Microsoft SMTP Server id 14.3.181.6; Wed, 22 Oct 2014 23:23:59 -0700 From: Yao Qi To: Victor Kamensky CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 4/5] ARM: read_pieced_value do big endian processing only in case of valid gdb_regnum References: <1413853021-4393-1-git-send-email-victor.kamensky@linaro.org> <1413853021-4393-5-git-send-email-victor.kamensky@linaro.org> <877fzsihdr.fsf@codesourcery.com> <87tx2vh3rz.fsf@codesourcery.com> Date: Thu, 23 Oct 2014 06:24:00 -0000 In-Reply-To: (Victor Kamensky's message of "Wed, 22 Oct 2014 22:43:29 -0700") Message-ID: <87ppdjgvdv.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00600.txt.bz2 Victor Kamensky writes: > I've posted updated V3 version only for this patch. I've modified > commit message to include more details as you suggested. > And I moved reg_offset var to more specific blocks as you noted. > Please take a look. Thanks, I'll take a look. > Would you like me to repost the whole series again (all 4 > patches) or it would be OK just like this? Well, we have two options usually, supposing you post a patch series, - if you only update one or two patches after review, you can just reply to reviewer's mail and post the updated patches in the same mail thread as your original post. It'll be convenient to search in archive, because all of them are in the same thread. - if you update all the patches, for example, change the design, better to post the updated series, like what you did for V2. In this case, you don't have to post them again. > > Also it came up on binutils@ patch discussion with Alan - > I do not have git commit permission. Is it my correct > expectation once folks are OK with the patches, you or > some other gdb maintainer will commit those? It is better for you to create your own account, and commit your patches after approval in the future. Please fill in the form here https://sourceware.org/cgi-bin/pdw/ps_form.cgi I think I can approve your request, so please fill in my mail address in box "email address of person who approved request". Once your account is ready, you can commit approved patches first. I am still thinking about patch 4/4, it may take some time. --=20 Yao (=E9=BD=90=E5=B0=A7)