From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35589 invoked by alias); 2 Sep 2015 04:22:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 35578 invoked by uid 89); 2 Sep 2015 04:21:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 02 Sep 2015 04:21:58 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 797ED461D3 for ; Wed, 2 Sep 2015 04:21:57 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t824LuRk029275 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Wed, 2 Sep 2015 00:21:57 -0400 From: Sergio Durigan Junior To: Gary Benson Cc: GDB Patches Subject: Re: [PATCH 2/2] Catching errors on probes-based dynamic linker interface References: <1440200253-28603-1-git-send-email-sergiodj@redhat.com> <1440200253-28603-3-git-send-email-sergiodj@redhat.com> <20150824084255.GA16508@blade.nx> <87r3msd5xr.fsf@redhat.com> <20150825124748.GA6948@blade.nx> <87wpwjgrmt.fsf@redhat.com> <87lhcq7raj.fsf@redhat.com> <20150901092449.GA6172@blade.nx> <87h9ne6r8j.fsf@redhat.com> <8737yx78u5.fsf@redhat.com> X-URL: http://blog.sergiodj.net Date: Wed, 02 Sep 2015 04:22:00 -0000 In-Reply-To: <8737yx78u5.fsf@redhat.com> (Sergio Durigan Junior's message of "Wed, 02 Sep 2015 00:18:10 -0400") Message-ID: <87pp215u3f.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2015-09/txt/msg00026.txt.bz2 On Wednesday, September 02 2015, I wrote: > On Tuesday, September 01 2015, I wrote: > >>> I am ok with doing this: >>> >>> TRY >>> { >>> probe_argc = get_probe_argument_count (pa->probe, frame); >>> } >>> CATCH (ex, RETURN_MASK_ERROR) >>> { >>> exception_print (gdb_stderr, ex); >>> probe_argc = 0; >>> } >>> END_CATCH >>> >>> If you put a big fat comment above the following block, e.g.: >>> >>> /* Note that failure of get_probe_argument_count will >>> set probe_argc == 0. This must result in returning >>> action = PROBES_INTERFACE_FAILED. */ >>> if (probe_argc == 2) >>> action = FULL_RELOAD; >>> else if (probe_argc < 2) >>> action = PROBES_INTERFACE_FAILED; >> >> Great, that works for me as well. I will update the patch here to >> address this. > > I took the liberty to modify and expand the comment; I hope you still > find it OK. Here's what I pushed. Pushed. https://sourceware.org/ml/gdb-cvs/2015-09/msg00002.html -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/