From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7910 invoked by alias); 9 Oct 2016 17:23:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7900 invoked by uid 89); 9 Oct 2016 17:23:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=notified, acceptance, fired, H*r:cmgw2 X-HELO: gproxy8-pub.mail.unifiedlayer.com Received: from gproxy8-pub.mail.unifiedlayer.com (HELO gproxy8-pub.mail.unifiedlayer.com) (67.222.33.93) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Sun, 09 Oct 2016 17:23:29 +0000 Received: (qmail 23240 invoked by uid 0); 9 Oct 2016 17:23:28 -0000 Received: from unknown (HELO cmgw2) (10.0.90.83) by gproxy8.mail.unifiedlayer.com with SMTP; 9 Oct 2016 17:23:28 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw2 with id tVPP1t0082f2jeq01VPSVP; Sun, 09 Oct 2016 11:23:26 -0600 X-Authority-Analysis: v=2.1 cv=PIacp5aC c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=CH0kA5CcgfcA:10 a=zstS-IiYAAAA:8 a=iUzWjU6k8VbTi_bVVvAA:9 a=4G6NA9xxw8l3yy4pmD5M:22 Received: from c-67-176-62-53.hsd1.co.comcast.net ([67.176.62.53]:40964 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1btHoq-0007WG-NC; Sun, 09 Oct 2016 11:23:24 -0600 From: Tom Tromey To: Tom Tromey Cc: Pedro Alves , Matt Rice , Yao Qi , "gdb-patches\@sourceware.org" Subject: Re: [RFA] PR python/13598 - add before_prompt event References: <1463806850-11001-1-git-send-email-tom@tromey.com> <87r3allziy.fsf@tromey.com> <8737mkz325.fsf@tromey.com> Date: Sun, 09 Oct 2016 17:23:00 -0000 In-Reply-To: <8737mkz325.fsf@tromey.com> (Tom Tromey's message of "Thu, 04 Aug 2016 14:34:10 -0600") Message-ID: <87pon9cu7n.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1btHoq-0007WG-NC X-Source-Sender: c-67-176-62-53.hsd1.co.comcast.net (bapiya) [67.176.62.53]:40964 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-10/txt/msg00200.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Pedro> The TUI uses this approach too nowadays. Tom> Thanks for mentioning that. I think it's another argument for accepting Tom> this patch. Hi! I'd like this patch to be reconsidered for approval. Today I tried rewriting this patch to use the new user_selected_context_changed observer. However, this runs into problems. First, this observer is not notified when a breakpoint is hit. It seems to me like it ought to be. One idea is to attach a second handler to the "stop" event. However, stop events are fired too often -- in particular if you set a breakpoint and put commands like this: silent cont ... the "stop" event will be fired for every breakpoint hit -- even though from a "user" point of view this isn't stopping. Given that the TUI uses the approach given in the before_prompt patch, and given that there haven't been any negative comments on the patch itself, I'd like to suggest approving this patch. As noted elsewhere, acceptance of this patch does not prevent inclusion of any future event. thanks, Tom