From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15427 invoked by alias); 2 Dec 2016 17:46:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15418 invoked by uid 89); 2 Dec 2016 17:46:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy=policy X-HELO: gproxy10-pub.mail.unifiedlayer.com Received: from gproxy10-pub.mail.unifiedlayer.com (HELO gproxy10-pub.mail.unifiedlayer.com) (69.89.20.226) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Fri, 02 Dec 2016 17:46:07 +0000 Received: (qmail 3794 invoked by uid 0); 2 Dec 2016 17:46:05 -0000 Received: from unknown (HELO cmgw4) (10.0.90.85) by gproxy10.mail.unifiedlayer.com with SMTP; 2 Dec 2016 17:46:05 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw4 with id F5m11u00r2f2jeq015m42K; Fri, 02 Dec 2016 10:46:05 -0700 X-Authority-Analysis: v=2.1 cv=Zpp+dbLG c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=L9H7d07YOLsA:10 a=9cW_t1CCXrUA:10 a=s5jvgZ67dGcA:10 a=IkcTkHD0fZMA:10 a=n5n_aSjo0skA:10 a=20KFwNOVAAAA:8 a=RmrkHA05navJAbrECsAA:9 a=QEXdDO2ut3YA:10 a=e_O65bzb51kRm2y5VmPK:22 Received: from 70-58-2-69.hlrn.qwest.net ([70.58.2.69]:38950 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.86_1) (envelope-from ) id 1cCruL-0002te-Dh; Fri, 02 Dec 2016 10:46:01 -0700 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA 1/8] Add gdb_ref_ptr.h References: <1480395946-10924-1-git-send-email-tom@tromey.com> <1480395946-10924-2-git-send-email-tom@tromey.com> Date: Fri, 02 Dec 2016 17:46:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 2 Dec 2016 13:07:50 +0000") Message-ID: <87pola8bs7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BWhitelist: no X-Exim-ID: 1cCruL-0002te-Dh X-Source-Sender: 70-58-2-69.hlrn.qwest.net (bapiya) [70.58.2.69]:38950 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2016-12/txt/msg00107.txt.bz2 >>>>> "Pedro" =3D=3D Pedro Alves writes: Pedro> Can you please remove them and see what breaks? Odd that this would= be Pedro> something about Python, given the class is being used in Python code Pedro> today? Yes, it's odd. If I comment out the nullptr_t overloads, I get build failures like: ../../binutils-gdb/gdb/python/py-exitedevent.c:31:20: error: no match for = =E2=80=98operator=3D=3D=E2=80=99 (operand types are =E2=80=98gdbpy_ref {aka= gdb::ref_ptr<_object, gdbpy_ref_policy>}=E2=80=99 and =E2=80=98long int=E2= =80=99) if (exited_event =3D=3D NULL) ^ ../../binutils-gdb/gdb/common/gdb_ref_ptr.h:183:13: note: template argume= nt deduction/substitution failed: In file included from ../../binutils-gdb/gdb/python/py-ref.h:23:0, from ../../binutils-gdb/gdb/python/py-event.h:27, from ../../binutils-gdb/gdb/python/py-event.c:21: ../../binutils-gdb/gdb/common/gdb_ref_ptr.h:171:13: note: candidate: templa= te bool gdb::operator=3D=3D(const T*, const gdb::ref= _ptr&) inline bool operator=3D=3D (const T *self, const ref_ptr &other) ^~~~~~~~ I don't understand why it picks this particular candidate, but re-reading it now I think my earlier theory is wrong. Tom