From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25481 invoked by alias); 12 Apr 2017 19:25:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25461 invoked by uid 89); 12 Apr 2017 19:25:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: gproxy7-pub.mail.unifiedlayer.com Received: from gproxy7-pub.mail.unifiedlayer.com (HELO gproxy7-pub.mail.unifiedlayer.com) (70.40.196.235) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with SMTP; Wed, 12 Apr 2017 19:25:55 +0000 Received: (qmail 4138 invoked by uid 0); 12 Apr 2017 19:25:55 -0000 Received: from unknown (HELO cmgw3) (10.0.90.84) by gproxy7.mail.unifiedlayer.com with SMTP; 12 Apr 2017 19:25:55 -0000 Received: from box522.bluehost.com ([74.220.219.122]) by cmgw3 with id 7XRs1v00V2f2jeq01XRvK0; Wed, 12 Apr 2017 13:25:55 -0600 X-Authority-Analysis: v=2.2 cv=VKStp5HX c=1 sm=1 tr=0 a=GsOEXm/OWkKvwdLVJsfwcA==:117 a=GsOEXm/OWkKvwdLVJsfwcA==:17 a=AzvcPWV-tVgA:10 a=20KFwNOVAAAA:8 a=rxgQF7_NmnrSwFmvpTIA:9 Received: from 75-166-65-226.hlrn.qwest.net ([75.166.65.226]:58122 helo=bapiya) by box522.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.87) (envelope-from ) id 1cyNto-0000jj-1h; Wed, 12 Apr 2017 13:25:52 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA v2 10/17] C++ify mi_parse References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-11-tom@tromey.com> <56430d1d-abb1-5e22-87dd-14158939d842@redhat.com> <87y3v561rm.fsf@tromey.com> <59b6549f-3232-64c0-2f3c-5469f1f3ca6f@redhat.com> <87tw5t5wnl.fsf@tromey.com> <77601650-1ad9-dc6e-b7a2-814a08f9348d@redhat.com> Date: Wed, 12 Apr 2017 19:25:00 -0000 In-Reply-To: <77601650-1ad9-dc6e-b7a2-814a08f9348d@redhat.com> (Pedro Alves's message of "Wed, 12 Apr 2017 19:37:41 +0100") Message-ID: <87pogh5sxs.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Exim-ID: 1cyNto-0000jj-1h X-Source-Sender: 75-166-65-226.hlrn.qwest.net (bapiya) [75.166.65.226]:58122 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTIyLmJsdWVob3N0LmNvbQ== X-SW-Source: 2017-04/txt/msg00365.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> FYI, I just now tried the hack below against master, and Pedro> that caught a few other cases that shouldn't have been Pedro> using memset for initialization. [...] Pedro> I wonder how bad would it be to put this hack in master. Guess Pedro> we could always add it behind an #if 0 at least, to make it easy Pedro> to enable for quick checking? I think it would be helpful if the compiler could warn about missing member initializations in a constructor. That would make something like the mi_parse change more robust, which I think is the reason for the memsets in the first place. Tom