From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18665 invoked by alias); 6 May 2017 14:13:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17318 invoked by uid 89); 6 May 2017 14:13:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-15.6 required=5.0 tests=BAYES_00,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,TRACKER_ID autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 06 May 2017 14:13:20 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A1A3E64450; Sat, 6 May 2017 14:13:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A1A3E64450 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=sergiodj@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com A1A3E64450 Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 768BB60BEF; Sat, 6 May 2017 14:13:21 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches , Simon Marchi , John Baldwin Subject: Re: [PATCH v3 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files) References: <20170425202309.15771-1-sergiodj@redhat.com> <20170505042951.32097-1-sergiodj@redhat.com> <20170505042951.32097-2-sergiodj@redhat.com> Date: Sat, 06 May 2017 14:13:00 -0000 In-Reply-To: (Pedro Alves's message of "Fri, 5 May 2017 17:35:25 +0100") Message-ID: <87pofmt6nz.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-05/txt/msg00163.txt.bz2 On Friday, May 05 2017, Pedro Alves wrote: > On 05/05/2017 05:29 AM, Sergio Durigan Junior wrote: > >> +# Native-target dependent makefile fragment comes in here. >> +@nat_extra_makefile_frag@ >> + > >> rename from gdb/config/i386/i386gnu.mh >> rename to gdb/config/i386/i386gnu-extra.mh >> index 070497f..93016ff 100644 >> --- a/gdb/config/i386/i386gnu.mh >> +++ b/gdb/config/i386/i386gnu-extra.mh > > ... > >> # MIG stubs are not yet ready for C++ compilation. >> -%_S.o %_U.o : COMPILE.post += -x c >> +%_S.o %_U.o : COMPILE.post +=-x c >> > > Spurious whitespace change. > >> NAT_GENERATED_FILES = notify_S.h notify_S.c \ >> - process_reply_S.h process_reply_S.c \ >> - msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \ >> - exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c >> + process_reply_S.h process_reply_S.c \ >> + msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \ >> + exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c > > Ditto. > > Apart from the naming issue and the spurious whitespace changes, > this looks fine to me. Thanks, pushed with the nits addressed. 21ea5acdd1bcfe89984b16b5bac730050c5cf05e -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/