From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 66103 invoked by alias); 8 Jun 2018 16:11:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66094 invoked by uid 89); 8 Jun 2018 16:11:27 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1806, consolidate, Cox, cox X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Jun 2018 16:11:25 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 4D2DA3023C for ; Fri, 8 Jun 2018 11:11:24 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id RJz2f0c6T79N3RJz2fULYZ; Fri, 08 Jun 2018 11:11:24 -0500 X-Authority-Reason: nr=8 Received: from 75-166-19-45.hlrn.qwest.net ([75.166.19.45]:42526 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fRJz2-000VFz-25; Fri, 08 Jun 2018 11:11:24 -0500 From: Tom Tromey To: Stan Cox Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [RFC][PATCH v3] Consolidate gdbserver global variables References: <3153f899-a653-9372-72fd-25ea874f7d3c@redhat.com> <44875dda-adc6-d9a4-940c-0c27aeac574b@redhat.com> <6a41763b-6949-2d32-37fa-9d3f1afceec1@redhat.com> <7d9764b6-d95a-96b4-b064-27ce539327cf@redhat.com> <9988957e-3bf8-cbe8-6c08-58706b11bd60@redhat.com> <9e844707-a2f8-c969-4d09-7ee2fa3bd1ed@redhat.com> Date: Fri, 08 Jun 2018 16:11:00 -0000 In-Reply-To: <9e844707-a2f8-c969-4d09-7ee2fa3bd1ed@redhat.com> (Stan Cox's message of "Tue, 8 May 2018 16:58:34 -0400") Message-ID: <87po11l0lw.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fRJz2-000VFz-25 X-Source-Sender: 75-166-19-45.hlrn.qwest.net (pokyo) [75.166.19.45]:42526 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-06/txt/msg00222.txt.bz2 >>>>> "Stan" == Stan Cox writes: Stan> * server.h (struct client_state): New. Stan> * server.c (cont_thread, general_thread, multi_process) Stan> (report_fork_events, report_vfork_events, report_exec_events) Stan> (report_thread_events, swbreak_feature, hwbreak_feature) Stan> (vCont_supported, disable_randomization, pass_signals) Stan> (program_signals, program_signals_p, last_status, last_ptid, own_buf): Stan> Moved to client_state. Stan> * remote-utils.c (remote_debug, noack_mode) Stan> (transport_is_reliable): Moved to client_state. Stan> * tracepoint.c (current_traceframe): Moved to client_state. I think this broke the mingw build. I configured with: ../binutils-gdb/configure --disable-{binutils,gas,gold,gprof,ld,sim} \ --host i686-w64-mingw32 --target i686-w64-mingw32 Then building: ../../../binutils-gdb/gdb/gdbserver/win32-low.c: In function 'int win32_create_inferior(const char*, const std::vector&)': ../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:3: error: 'last_ptid' was not declared in this scope last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0); ^~~~~~~~~ ../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:3: note: suggested alternative: 'last_sig' last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0); ^~~~~~~~~ last_sig ../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:62: error: 'last_status' was not declared in this scope last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0); ^~~~~~~~~~~ ../../../binutils-gdb/gdb/gdbserver/win32-low.c:709:62: note: suggested alternative: 'cached_status' last_ptid = win32_wait (pid_to_ptid (current_process_id), &last_status, 0); ^~~~~~~~~~~ cached_status thanks, Tom