From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16804 invoked by alias); 11 Aug 2018 15:02:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16784 invoked by uid 89); 11 Aug 2018 15:02:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:652 X-HELO: gateway22.websitewelcome.com Received: from gateway22.websitewelcome.com (HELO gateway22.websitewelcome.com) (192.185.46.225) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 11 Aug 2018 15:02:51 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway22.websitewelcome.com (Postfix) with ESMTP id 20542CC23 for ; Sat, 11 Aug 2018 10:02:50 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id oVPmftXLskBj6oVPmfAl3T; Sat, 11 Aug 2018 10:02:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hJiMytVTrBui5+2FSSrA2O1Sax2umeBcoJqYx1fE63c=; b=CF0+h53LqkJwZHASip5igOED7+ dZdQViekAXMCjXhBFwIsxU0X65y4sb3Eu2+5urHUl0fCfSLsRtao4NG5G1IKIO4FlzHPhPh741qHV 6hytGvOfNRa/77h9iSzjqL6+6; Received: from 75-166-85-72.hlrn.qwest.net ([75.166.85.72]:57188 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1foVPl-003d7B-SB; Sat, 11 Aug 2018 10:02:49 -0500 From: Tom Tromey To: Keith Seitz Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 5/9] Change decode_compound_collector to use std::vector References: <20180810232534.481-1-keiths@redhat.com> <20180810232534.481-6-keiths@redhat.com> Date: Sat, 11 Aug 2018 15:02:00 -0000 In-Reply-To: <20180810232534.481-6-keiths@redhat.com> (Keith Seitz's message of "Fri, 10 Aug 2018 16:25:30 -0700") Message-ID: <87pnypt086.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-08/txt/msg00320.txt.bz2 >>>>> "Keith" == Keith Seitz writes: Keith> This patch changes decode_compound_collector to use std::vector instead of Keith> VEC, eliminating a cleanup in the process. Keith> - /* Releases ownership of the collected symbols and returns them. */ Keith> - VEC (symbolp) *release_symbols () Keith> + /* Return all symbols collected. */ Keith> + std::vector release_symbols () Keith> { Keith> - VEC (symbolp) *res = m_symbols; Keith> - m_symbols = NULL; Keith> - return res; Keith> + return m_symbols; Keith> } Won't this end up copying m_symbols? Tom