From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41362 invoked by alias); 23 Sep 2018 21:13:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 41350 invoked by uid 89); 23 Sep 2018 21:13:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.146.195) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 23 Sep 2018 21:13:36 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 72F02292758 for ; Sun, 23 Sep 2018 16:13:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 4Bh9gHON2PvAd4Bh9g9zv5; Sun, 23 Sep 2018 16:13:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ylf3e/9jaSsiC7IY/dDRB8OTs/7wxC3fHqmtnz4Qnmc=; b=rpXv6vHNSeyEtUfWM/U3+9FHYE uvP1zWjP0a26WS3J4R9WcJwspxcYgIR09QgVP6iRbr5QbgooiZzjavKli0E2x0opxH75MeUPvc8iF F6XhOyblmfR9GKffK54Ea2vkJ; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:41344 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g4Bh9-001RYU-5f; Sun, 23 Sep 2018 16:13:35 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Subject: Re: [RFA 14/15] Make psymtab_storage::free_psymtabs private References: <20180510222357.27332-1-tom@tromey.com> <20180510222357.27332-15-tom@tromey.com> Date: Sun, 23 Sep 2018 21:13:00 -0000 In-Reply-To: (Simon Marchi's message of "Wed, 18 Jul 2018 10:35:52 -0400") Message-ID: <87pnx3lxxd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00782.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> +struct partial_symtab * >> +psymtab_storage::allocate_psymtab () >> +{ >> + struct partial_symtab *psymtab; >> + >> + if (free_psymtabs) Simon> != nullptr Simon> Otherwise, LGTM. I made this change. Tom