From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20936 invoked by alias); 1 Oct 2018 09:15:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20609 invoked by uid 89); 1 Oct 2018 09:15:05 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=D*ca, Hx-languages-length:591, renamed, reopen X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.4.169) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Oct 2018 09:14:58 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 746C8400D85C3 for ; Mon, 1 Oct 2018 04:14:57 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 6uI3guDgZkBj66uI4g1izb; Mon, 01 Oct 2018 04:14:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OmqRjbDRUewHjy9qqUE2TlheOMgy3wV35ZvF1eiUfGM=; b=e8sJPudszwhvAZP9FsWCTSch1i zqDatbr5AjD0zRRQ2cqFl50/KY/y+phAsnNMJ79vmgrZu/D5fcmWkBaYNzOqPTAmvslCCS/9TBzy0 PPmJ92fAcCP0qQBrm154LD0JA; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:59698 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g6uI3-00404j-G1; Mon, 01 Oct 2018 04:14:55 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFC 5/6] Do not reopen temporary files References: <20180926111130.18956-1-tom@tromey.com> <20180926111130.18956-6-tom@tromey.com> Date: Mon, 01 Oct 2018 09:15:00 -0000 In-Reply-To: (Simon Marchi's message of "Fri, 28 Sep 2018 23:22:25 -0400") Message-ID: <87pnwugh9t.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-10/txt/msg00006.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> + /* Order matters here; we want FILE to be closed before FILENAME_TEMP is >> + unlinked, because on MS-Windows one cannot delete a file that is >> + still open. (Don't call anything here that might throw until >> + file_closer is created.) So, we wrap the unlinker in an optional Simon> I just noticed this refers to file_closer, a variable that doesn't exist anymore Simon> (or has been renamed). Thanks. I've removed the parenthesized sentence, because it no longer applies. Tom