From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 59266 invoked by alias); 16 Nov 2018 23:21:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58759 invoked by uid 89); 16 Nov 2018 23:21:28 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=encrypted X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Nov 2018 23:21:26 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8463630820C6; Fri, 16 Nov 2018 23:21:25 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 52029608E8; Fri, 16 Nov 2018 23:21:25 +0000 (UTC) From: Sergio Durigan Junior To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [FYI] Handle TYPE_CODE_PTR when printing Rust types References: <20181116223305.12130-1-tom@tromey.com> Date: Fri, 16 Nov 2018 23:21:00 -0000 In-Reply-To: <20181116223305.12130-1-tom@tromey.com> (Tom Tromey's message of "Fri, 16 Nov 2018 15:33:05 -0700") Message-ID: <87pnv44nij.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00262.txt.bz2 On Friday, November 16 2018, Tom Tromey wrote: > This changes the Rust type printers to handle TYPE_CODE_PTR. The > current approach is not ideal, because currently the code can't > distinguish between mut and const, or between pointers and references. > (These are debuginfo deficiencies, for which there are rustc bugs on > file.) > > Meanwhile, this at least clears up the case seen in PR rust/23625. > > Tested on x86-64 Fedora 28 using the current Rust stable compiler. > > gdb/ChangeLog > 2018-11-16 Tom Tromey > > PR rust/23625: > * rust-lang.c (rust_internal_print_type): Handle TYPE_CODE_PTR. > > gdb/testsuite/ChangeLog > 2018-11-16 Tom Tromey > > PR rust/23625: > * gdb.rust/simple.exp: Add ptype test. > --- > gdb/ChangeLog | 5 +++++ > gdb/rust-lang.c | 14 ++++++++++++++ > gdb/testsuite/ChangeLog | 5 +++++ > gdb/testsuite/gdb.rust/simple.exp | 1 + > 4 files changed, 25 insertions(+) > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 4995d551979..ed5123d6b22 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,8 @@ > +2018-11-16 Tom Tromey > + > + PR rust/23625: > + * rust-lang.c (rust_internal_print_type): Handle TYPE_CODE_PTR. > + > 2018-11-16 Alan Hayward > > PR gdb/22736: > diff --git a/gdb/rust-lang.c b/gdb/rust-lang.c > index 152413a612f..12a9c0b4895 100644 > --- a/gdb/rust-lang.c > +++ b/gdb/rust-lang.c > @@ -918,6 +918,20 @@ rust_internal_print_type (struct type *type, const char *varstring, > } > break; > > + case TYPE_CODE_PTR: > + { > + if (TYPE_NAME (type) != nullptr) > + fputs_filtered (TYPE_NAME (type), stream); > + else > + { > + /* We currently can distinguish between pointers and > + references. */ I understand you'll send a new version of the patch soon, but this caught my attention. I think you meant to say "... can't distinguish...", right? At least that's what I understand from the code below. Thanks. > + fputs_filtered ("*mut ", stream); > + type_print (TYPE_TARGET_TYPE (type), "", stream, 0); > + } > + } > + break; > + > default: > c_printer: > c_print_type (type, varstring, stream, show, level, flags); > diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog > index c0de6f2d6cd..4aa9bceb545 100644 > --- a/gdb/testsuite/ChangeLog > +++ b/gdb/testsuite/ChangeLog > @@ -1,3 +1,8 @@ > +2018-11-16 Tom Tromey > + > + PR rust/23625: > + * gdb.rust/simple.exp: Add ptype test. > + > 2018-11-16 Alan Hayward > > PR gdb/22736: > diff --git a/gdb/testsuite/gdb.rust/simple.exp b/gdb/testsuite/gdb.rust/simple.exp > index 956a6ca6fee..e26435abb29 100644 > --- a/gdb/testsuite/gdb.rust/simple.exp > +++ b/gdb/testsuite/gdb.rust/simple.exp > @@ -54,6 +54,7 @@ gdb_test "print *&c" " = 0" > gdb_test "print *(&c as &i32)" " = 0" > gdb_test "print *(&c as *const i32)" " = 0" > gdb_test "print *(&c as *mut i32)" " = 0" > +gdb_test "ptype &c as *mut i32" "\\*mut i32" > > gdb_test "print/c f\[0\]" " = 104 'h'" > > -- > 2.17.2 -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/