From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11394 invoked by alias); 12 Jan 2019 17:01:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11379 invoked by uid 89); 12 Jan 2019 17:01:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=speaking, distinction, prevent X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.77) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Jan 2019 17:01:22 +0000 Received: from cm10.websitewelcome.com (cm10.websitewelcome.com [100.42.49.4]) by gateway34.websitewelcome.com (Postfix) with ESMTP id 3FC6E2237828 for ; Sat, 12 Jan 2019 11:01:21 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id iMevg29112PzOiMevgfhdM; Sat, 12 Jan 2019 11:01:21 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Iyj2SYvp/zjQnOxZ1nAMAbmAU6fkPT6MVaEEn7cd4KY=; b=n9CPQz9yQIzaY4GVFy6wF6e/FO UYl/j4o+0u0Nn2qOj/Mp81QiazVmh48jv27WOnsuR2ed0UCwmWC6CuuuqKtKftZvsIMo3Vy5mMTlV xwXot/F0/pQPbaOQbxGJQdXa1; Received: from 75-166-72-210.hlrn.qwest.net ([75.166.72.210]:38252 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1giMeu-002BBb-VL; Sat, 12 Jan 2019 11:01:21 -0600 From: Tom Tromey To: Eli Zaretskii Cc: Simon Marchi , gdb-patches@sourceware.org, palves@redhat.com Subject: Re: [PATCH] Fix MI output for multi-location breakpoints References: <20190111001516.4761-1-simon.marchi@ericsson.com> <83lg3rhb6r.fsf@gnu.org> <7cf31d37-3931-bbac-07f2-c61f57be142c@ericsson.com> <83y37qgail.fsf@gnu.org> Date: Sat, 12 Jan 2019 17:01:00 -0000 In-Reply-To: <83y37qgail.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 11 Jan 2019 23:16:50 +0200") Message-ID: <87pnt1vmhr.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-01/txt/msg00288.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: >> In reality, it's included in all versions from 5.1 and up. So it >> seems odd to list 5.2 and 5.3 specifically. Do you have a >> suggestion to address this? Eli> Say "used by" instead of "included in"? Yeah, I think that would be clearer. The current text makes it sounds as though MI1 were limited to just these releases, whereas it's actually the case that these releases included MI1 but not anything later. Speaking of, it seems like we could remove MI1. Eli> That's not what bothered me. What bothered me was that we released a Eli> GDB with this MI syntax without fixing it first. I'm wondering how to Eli> prevent such mistakes in the future. Yeah, this is unfortunate. Also, I think it is hard to see a programmatic way around this, at least given gdb's current ui-out approach. As I see it, the problem is that at a given point, one can make either a tuple emitter or a list emitter, but otherwise there's no distinction in the source. If you choose the wrong one this is hard to see in review, and there's really nothing else checking the grammar. Maybe the MI ui-out object could somehow enforce the constraint, by asserting if the wrong thing is done. Though it would need a bypass anyhow because there are already bugs. Tom