From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120751 invoked by alias); 28 Feb 2019 18:55:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120735 invoked by uid 89); 28 Feb 2019 18:55:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Zaretskii, zaretskii X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Feb 2019 18:55:29 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0D1F465F4B; Thu, 28 Feb 2019 18:55:28 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id C50704384; Thu, 28 Feb 2019 18:55:27 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: MinGW build of GDB 8.2.90 References: <20190227055112.4A5E782D7B@joel.gnat.com> <837edjkbp4.fsf@gnu.org> Date: Thu, 28 Feb 2019 18:55:00 -0000 In-Reply-To: <837edjkbp4.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 28 Feb 2019 20:30:31 +0200") Message-ID: <87pnrbivz4.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-02/txt/msg00571.txt.bz2 On Thursday, February 28 2019, Eli Zaretskii wrote: >> From: Joel Brobecker >> Date: Wed, 27 Feb 2019 09:51:12 +0400 (+04) >> >> I have just finished creating the gdb-8.2.90 pre-release. >> It is available for download at the following location: >> >> ftp://sourceware.org/pub/gdb/snapshots/branch/gdb-8.2.90.tar.xz > > Thanks, I've built this with mingw.org's MinGW and bumped into a few > problems. > > First, the recent changes to support IPv6 caused compilation errors in > several files. The problem is with several fragments such as this > one: > > #ifdef USE_WIN32API > #include > #include > #else > ... > > mingw.org's MinGW doesn't have wspiapi.h. Moreover, the Microsoft > documentation indicates that to get prototypes of getaddrinfo, > freeaddrinfo, etc. one needs to include ws2tcpip.h (and not include > winsock2.h separately), see, for example, > > https://docs.microsoft.com/en-us/windows/desktop/api/ws2tcpip/nf-ws2tcpip-getaddrinfo > > Sergio, can you tell why you used wspiapi.h instead? Thanks for the report, Eli. To be honest, I don't remember where I found the information that wspiapi.h needed to be used, but I do remember finding it somewhere on the internet, and since I don't use Windows, I assumed it was correct. However, and more importantly, I remember testing the whole patch by compiling it using a mingw32 compiler on Fedora, and it was working correctly. In fact, we even have a mingw32 builder on our BuildBot (running on Fedora), and it is still compiling GDB without problems: https://gdb-build.sergiodj.net/builders/Fedora-x86_64-w64-mingw32 So apparently this error is only triggered when you use mingw on Windows...? I don't know. > Is it okay to push changes such as the one below, master and branch > (after filing a Bugzilla report)? > > --- ./gdb/common/netstuff.c~0 2019-02-27 06:51:50.000000000 +0200 > +++ ./gdb/common/netstuff.c 2019-02-28 08:56:07.511568800 +0200 > @@ -21,8 +21,11 @@ > #include > > #ifdef USE_WIN32API > -#include > -#include > +#if _WIN32_WINNT < 0x0501 > +# undef _WIN32_WINNT > +# define _WIN32_WINNT 0x0501 > +#endif > +#include > #else > #include > #include As I said, I don't use Windows and don't understand the system, but if these changes fix the problem for you, I'd say they're justified and should be pushed (even though I don't understand the "if _WIN32_WINNT..." part). > Note that one other side effect of the IPv6 support additions is that > on MS-Windows GDB will no longer run on versions older than XP, I > guess this is something that should be mentioned in NEWS? I confess I did not know that. If that's the case, then we should indeed notify the users via the NEWS file, IMO. > The other two problems were minor warning, one in tui.c about an > unused variable 'cap' (it is not used on Windows) and another in > xml-syscall.c: > > CXX xml-syscall.o > xml-syscall.c: In function 'bool xml_list_syscalls_by_group(gdbarch*, const char*, std::vector*)': > xml-syscall.c:475:14: warning: types may not be defined in a for-range-declaration > for (const struct syscall_desc *sysdesc : groupdesc->syscalls) > ^~~~~~ > > I solved the latter by removing "struct" from the declaration. This > is with GCC 6.3.0; is that a GCC bug? is removing "struct" the right > solution? Yeah, this is the right thing to do. I remember having to do this a few times, and seeing other patches doing the same. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/