From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54625 invoked by alias); 6 Mar 2019 21:18:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 54373 invoked by uid 89); 6 Mar 2019 21:18:01 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,TIME_LIMIT_EXCEEDED autolearn=unavailable version=3.3.1 spammy=our X-HELO: gateway31.websitewelcome.com Received: from gateway31.websitewelcome.com (HELO gateway31.websitewelcome.com) (192.185.144.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 21:17:51 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 3F0A4250408 for ; Wed, 6 Mar 2019 15:17:50 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1dvChbS8m90on1dvChudkq; Wed, 06 Mar 2019 15:17:50 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Tbpr/t1I87dPx8AKOtxn31/xKaIwMs0rv1n5lS46y+8=; b=r2kW74r6tkZjC8Pe5VxHqDvjxE bkA+AG6UGMNlC6nQQCGTWCKANtx9rNZ6Xt6z/Ih1g9EoxN0Wqth3bIi5Dg07bjSGWKmI+QjNPiueS 6FtM8e9JxwymuQN+QfZiJIZwD; Received: from 75-166-85-218.hlrn.qwest.net ([75.166.85.218]:60216 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1h1dvC-001WDk-1T; Wed, 06 Mar 2019 15:17:50 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 07/22] Remove last cleanups from solib-svr4.c References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-8-tom@tromey.com> Date: Wed, 06 Mar 2019 21:18:00 -0000 In-Reply-To: (Pedro Alves's message of "Wed, 6 Mar 2019 19:32:42 +0000") Message-ID: <87pnr3ln2a.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-03/txt/msg00127.txt.bz2 >>>>> "Pedro" == Pedro Alves writes: Pedro> When passing lambdas as last argument to a function, I think indenting Pedro> like this reads clearer: Pedro> auto cleanup = make_scope_exit ([&] () Pedro> { Pedro> svr4_free_library_list (&list->head); Pedro> }); I agree. I made this change here & in another patch in the series. Pedro> If others agree, I'd vote for having a similar rule of our own. Let's do it. Tom