From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1262 invoked by alias); 5 Jun 2019 13:28:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1252 invoked by uid 89); 5 Jun 2019 13:28:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.45.27) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Jun 2019 13:28:50 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id D08E7400CD217 for ; Wed, 5 Jun 2019 07:28:07 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id YVyDhF2PGdnCeYVyDhsXI1; Wed, 05 Jun 2019 08:28:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ov5ajjVSEHGlWSASj8oTDFdQgRAVqFrLWThvLUGKsCA=; b=wsTALtC74drfe5ZeE0/BjLGtcK 29y22N9mnAuiqs7SZzfnwJA5XqX0kHrITL6XiXm9ZjJ2ijdUtrWr2Xz6mELTxeqtE25YguVZlHDCO uMdGqLNRHLA+txfIGPcsk7QXk; Received: from 174-29-48-168.hlrn.qwest.net ([174.29.48.168]:37292 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1hYVyD-004LSf-AS; Wed, 05 Jun 2019 08:28:49 -0500 From: Tom Tromey To: Philippe Waroquiers Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [RFA] Give thread names in thread events, give Ada task names in more output. References: <20190518182306.22937-1-philippe.waroquiers@skynet.be> <87imtml9o6.fsf@tromey.com> <1559684425.1454.52.camel@skynet.be> Date: Wed, 05 Jun 2019 13:28:00 -0000 In-Reply-To: <1559684425.1454.52.camel@skynet.be> (Philippe Waroquiers's message of "Tue, 04 Jun 2019 23:40:25 +0200") Message-ID: <87pnnsi2jz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00122.txt.bz2 >>>>> "Philippe" == Philippe Waroquiers writes: >> Are there spots calling target_pid_to_str that do not want to call the >> new function? Philippe> We have different "spot kinds" calling target_pid_to_str. Philippe> Some spots have a thread_info*, they get the ptid from this thread_info Philippe> to call target_pid_to_str. These are trivial to convert. Philippe> Some spots have just a ptid. Calling thread_target_id_str implies to Philippe> convert the ptid to a thread_info*. This can return a null ptr, and so Philippe> could lead to a problem. Philippe> Maybe we could define a new function such as: Philippe> target_pid_to_thr_id_str (ptid) Philippe> that tries to convert ptid to a thread_info*. Philippe> If it finds one, then it returns thread_target_id_str (th) Philippe> otherwise it returns target_pid_to_str (ptid). Philippe> This should be a relatively mechanical and not risky change, but we Philippe> have about 200 calls to target_pid_to_str in various user messages Philippe> and (mostly) debug info. Philippe> What do you think ? I think when I wrote that line, I hadn't yet appreciated that the patch was just exposing a previously private function. So, while it may still make sense to switch other calls to use it, I don't think it is a requirement for this patch. Tom