From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114506 invoked by alias); 26 Jun 2019 17:30:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114497 invoked by uid 89); 26 Jun 2019 17:30:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HTo:U*palves X-HELO: gateway20.websitewelcome.com Received: from gateway20.websitewelcome.com (HELO gateway20.websitewelcome.com) (192.185.68.24) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jun 2019 17:30:53 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway20.websitewelcome.com (Postfix) with ESMTP id 72610400FA8C4 for ; Wed, 26 Jun 2019 11:29:05 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gBkyhMr4a90ongBkyhKi4Q; Wed, 26 Jun 2019 12:30:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=D/TwUZe3dZKCAAjdZq1dxAG0vTrX3Pfko7bMXk4m0AU=; b=G4judX5phVmUM20hLQGzd12hpU 5MsuL+vAArv95q5SGMSgAkkW6N3skyINukfRL8Z3jsd+YwrsyhvFCMyY3wyjul08Ai7MuYg+0SbyT P8dIWAeSHndhWXJfOq7ImIGl1; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:41650 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hgBkx-0025Gs-WA; Wed, 26 Jun 2019 12:30:52 -0500 From: Tom Tromey To: Pedro Alves Cc: Kevin Buettner , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Prefer symtab symbol over minsym for function names in non-contiguous blocks References: <20190608195434.26512-1-kevinb@redhat.com> <20190608195434.26512-2-kevinb@redhat.com> <8f624a5d-58ba-8c6b-064d-9a82a63a6769@redhat.com> Date: Wed, 26 Jun 2019 17:30:00 -0000 In-Reply-To: <8f624a5d-58ba-8c6b-064d-9a82a63a6769@redhat.com> (Pedro Alves's message of "Fri, 21 Jun 2019 15:26:36 +0100") Message-ID: <87pnn05k50.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00601.txt.bz2 >> GDB is prefering this minsym over the the name provided by the >> DWARF info due to some really old code in GDB which handles >> "certain pathological cases". See the first big block comment >> in find_frame_funname for more information. Pedro> Yuck! >> I considered removing the code for this corner case entirely, but it >> seems as though it might still be useful, so I left it intact. Pedro> Yeah, I'd be inclined to try removing it too. The comment Pedro> smells of a.out or stabs limitations. But I'm not 100% sure, Pedro> and I'm sympathetic with forward incremental progress. That code dates to the creation of the sourceware repository. I think it could be deleted. And, if it's still a bug somehow, it seems better to fix it some other way, and not let stabs and/or a.out weirdness into the generic code. Tom