From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81954 invoked by alias); 26 Jun 2019 21:05:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81944 invoked by uid 89); 26 Jun 2019 21:05:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-9.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway21.websitewelcome.com Received: from gateway21.websitewelcome.com (HELO gateway21.websitewelcome.com) (192.185.45.91) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 26 Jun 2019 21:05:37 +0000 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway21.websitewelcome.com (Postfix) with ESMTP id F0F21400D7458 for ; Wed, 26 Jun 2019 16:05:35 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id gF6lhRpJd2qH7gF6lhaPXh; Wed, 26 Jun 2019 16:05:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=NH6OZU+SgH4ihdKWIOCwWzXZdWqAI65xWbt1cokDUcw=; b=PUaJZCO7uFBRQja2D86p8GkNNF 22nV9z8MFaVDwiDGmYIGIPfDySj76UU6CVvaY674BMZs8VU+PI5W3bYtctm8tTdf+aOOLulfqA6kL RYx1fdImjXqg9TERixVTnNc37; Received: from 75-166-12-78.hlrn.qwest.net ([75.166.12.78]:43372 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1hgF6l-0032lR-NE; Wed, 26 Jun 2019 16:05:35 -0500 From: Tom Tromey To: Eli Zaretskii Cc: Christian Biesinger , gdb-patches@sourceware.org Subject: Re: [PATCH] Add an Objfile.lookup_global_symbol function References: <20190625220832.247935-1-cbiesinger@google.com> <83pnn0jr39.fsf@gnu.org> Date: Wed, 26 Jun 2019 21:05:00 -0000 In-Reply-To: <83pnn0jr39.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 26 Jun 2019 18:36:58 +0300") Message-ID: <87pnn03vmp.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-06/txt/msg00605.txt.bz2 >>>>> "Eli" == Eli Zaretskii writes: >> +@defun Objfile.lookup_global_symbol (name @r{[}, domain@r{]}) >> +Searches for a global symbol by name in this objfile. Optionally, the Eli> ^^ Eli> Two spaces between sentences (here and elsewhere in the patch), Eli> please. I wonder whether the parameter names ought to be wrapped in @var{}. Tom