From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91767 invoked by alias); 9 Sep 2019 17:56:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91528 invoked by uid 89); 9 Sep 2019 17:56:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-5.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:351 X-HELO: gateway34.websitewelcome.com Received: from gateway34.websitewelcome.com (HELO gateway34.websitewelcome.com) (192.185.149.62) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 09 Sep 2019 17:56:19 +0000 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway34.websitewelcome.com (Postfix) with ESMTP id AA99381A895 for ; Mon, 9 Sep 2019 12:56:17 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 7Nthil8VGdnCe7Nthi6Y1L; Mon, 09 Sep 2019 12:56:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=JnbSTGJ014K3vjI0Mm/y+ORMnp5HxWpHd++3tYWRfNc=; b=L2AY6/q+0kLslLvkzGAQ7yxk70 ovO1znI30A53IU5ayZWax5ax8q4SfpMVLZzgNRR5tLc+aIFX7/I01hNHE/eZYGpl10KZtoqch7kOS AHPVjbpwsplrmdbodgZBjm2ln; Received: from 71-218-73-27.hlrn.qwest.net ([71.218.73.27]:52472 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1i7Nth-000uYn-Cm; Mon, 09 Sep 2019 12:56:17 -0500 From: Tom Tromey To: libor.bukata@oracle.com Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: Fix a crash in compile_to_object function References: <3ad99625-43ff-a450-6e50-d83242224443@oracle.com> <1742a18e-dfcb-6d80-03cc-5696a0cd3cd3@redhat.com> Date: Mon, 09 Sep 2019 17:56:00 -0000 In-Reply-To: (libor bukata's message of "Fri, 6 Sep 2019 19:11:23 +0200") Message-ID: <87pnk99wvz.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2019-09/txt/msg00133.txt.bz2 >>>>> ">" == libor bukata writes: >> I have no objections to use 'os_rx != NULL ? os_rx : ""' instead; it >> is more portable. Note that NULL should be used instead of nullptr as >> nullptr is available since C++11. Just FYI, gdb uses C++11 nowadays, so nullptr is fine. Tom