From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40129 invoked by alias); 26 Sep 2019 17:51:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40119 invoked by uid 89); 26 Sep 2019 17:51:11 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=HTo:U*palves X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 26 Sep 2019 17:51:10 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 018A710C0929; Thu, 26 Sep 2019 17:51:09 +0000 (UTC) Received: from localhost (unused-10-15-17-196.yyz.redhat.com [10.15.17.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id C1CBD1017CD6; Thu, 26 Sep 2019 17:51:07 +0000 (UTC) From: Sergio Durigan Junior To: Pedro Alves Cc: Tom Tromey , GDB Patches , Eli Zaretskii , Ruslan Kabatsayev Subject: Re: [PATCH v5] Improve ptrace-error detection on Linux targets References: <20190819032918.3536-1-sergiodj@redhat.com> <20190926042155.31481-1-sergiodj@redhat.com> <87d0fngdyx.fsf@tromey.com> <95b321a8-4399-8bf0-1794-6089bc7aac3f@redhat.com> Date: Thu, 26 Sep 2019 17:51:00 -0000 In-Reply-To: <95b321a8-4399-8bf0-1794-6089bc7aac3f@redhat.com> (Pedro Alves's message of "Thu, 26 Sep 2019 18:48:44 +0100") Message-ID: <87pnjnhrp1.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2019-09/txt/msg00537.txt.bz2 On Thursday, September 26 2019, Pedro Alves wrote: > On 9/26/19 6:32 PM, Tom Tromey wrote: >>>>>>> "Sergio" == Sergio Durigan Junior writes: >> >> Sergio> Changes from v4: >> Sergio> - Don't add 'dont_throw' optional argument to gdb_dlopen; use >> Sergio> conventional try..catch. >> >> Sergio> - Use snprintf when printing to 'own_buf' and make sure we don't >> Sergio> overflow the buffer. >> >> Thank you for doing this. >> I think this is ok, please check it in. > > Please give me a bit to review before merging. I think I spotted an issue, > but I haven't had a chance to take a look at it since before Cauldron. Ops, I just saw this message now, after pushing the patch. Would you like me to revert it? -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/