From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111051 invoked by alias); 3 Mar 2020 16:32:06 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110998 invoked by uid 89); 3 Mar 2020 16:32:06 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.221) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Mar 2020 16:32:04 +0000 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 8952E50A94 for ; Tue, 3 Mar 2020 10:31:57 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9ASaj1sIwRP4z9ASajPWth; Tue, 03 Mar 2020 10:31:57 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zzR4c7bHdzBzDbpzoyjgVcF0vlUH8hSjdutiXQgp4S0=; b=pR+BHeDE5XKyS78KYFVzPKKRht C6SHQtK1S92fpYiheSgIPOhxHskwy6x256TKDdTNCdq9mfB5E2v3JL6nV+muR/jSSwEn4SGX9LLpq /zCvYFw2xed0BeXgQqwKAmiBk; Received: from 184-96-250-69.hlrn.qwest.net ([184.96.250.69]:47710 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j9ASa-003EFF-IJ; Tue, 03 Mar 2020 09:31:56 -0700 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org, AlokKumar.Sharma@amd.com Subject: Re: [PATCHv2] gdb/fortran: Fix printing of logical true values for Flang References: <20200302182152.12819-1-andrew.burgess@embecosm.com> Date: Tue, 03 Mar 2020 16:32:00 -0000 In-Reply-To: <20200302182152.12819-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Mon, 2 Mar 2020 18:21:52 +0000") Message-ID: <87pndtcsck.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-03/txt/msg00058.txt >>>>> "Andrew" == Andrew Burgess writes: Andrew> Thanks for looking into this. I think that the best solution right Andrew> now will be to handle TYPE_CODE_BOOL in f_val_print rather than Andrew> modifying generic_val_print_bool. Agreed. Andrew> The other possibility would be, I think, to add a new field to 'struct Andrew> language_defn' and use this in generic_val_print_bool instead of Andrew> comparing the value of current_lanuage directly, however, this isn't Andrew> the common approach, so I'd prefer to handle this case just like other Andrew> TYPE_CODE_* are handled for now. It would be nice if we could get away from having separate printing code for each language. I don't know how practical this is though. Andrew> I know that in places within GDB we do compare the value of Andrew> current_lanuage to the know language structures, but I'd like to move Andrew> us away from doing this. Also agreed. Tom